Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework kobs architecture watcher #317

Merged

Conversation

ricoberger
Copy link
Member

@ricoberger ricoberger force-pushed the rework-kobs-architecture-watcher branch 3 times, most recently from bf9e5bf to adb8215 Compare May 2, 2022 14:01
pkg/hub/store/store.go Show resolved Hide resolved
pkg/hub/store/store.go Show resolved Hide resolved
pkg/hub/store/store_test.go Show resolved Hide resolved
pkg/hub/store/store.go Show resolved Hide resolved
@ricoberger ricoberger force-pushed the rework-kobs-architecture-watcher branch from adb8215 to 67d8785 Compare May 3, 2022 06:32
@codecov-commenter
Copy link

Codecov Report

Merging #317 (67d8785) into rework-kobs-architecture (3e8982c) will increase coverage by 0.59%.
The diff coverage is 47.82%.

@@                     Coverage Diff                      @@
##           rework-kobs-architecture     #317      +/-   ##
============================================================
+ Coverage                     44.70%   45.29%   +0.59%     
============================================================
  Files                            46       50       +4     
  Lines                          2691     3009     +318     
============================================================
+ Hits                           1203     1363     +160     
- Misses                         1426     1561     +135     
- Partials                         62       85      +23     
Impacted Files Coverage Δ
cmd/kobs/hub/config/config.go 100.00% <ø> (ø)
pkg/api/hub/hub.go 0.00% <0.00%> (ø)
pkg/hub/watcher/watcher.go 21.23% <21.23%> (ø)
cmd/kobs/hub/hub.go 21.48% <21.95%> (+3.37%) ⬆️
pkg/hub/store/store.go 46.34% <45.00%> (-1.35%) ⬇️
pkg/hub/watcher/request.go 90.32% <90.32%> (ø)
pkg/hub/watcher/instrument.go 100.00% <100.00%> (ø)
pkg/hub/watcher/worker/worker.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8982c...67d8785. Read the comment docs.

@ricoberger ricoberger merged commit f4c40dd into rework-kobs-architecture May 3, 2022
@ricoberger ricoberger deleted the rework-kobs-architecture-watcher branch May 3, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants