[app] Improve instrumentation middleware #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We unified the exported function name across the httpmetrics, httplog and httptracer middleware. They all export a Handler function which can be used in the router. The logging and tracing middleware also catchs panics now to write a log line / create a span. Besides that we also fixed a small bug caused by the notification drawer, introduced in #389. Because of the notification drawer the drawer in the PageSectionContent component wasn't using it's full height anymore, which caused problems for the select boxes in the toolbar and the pages showing graphs via cytoscape. This should be fixed now.
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 45.37% 45.20% -0.18%
==========================================
Files 134 134
Lines 10338 10377 +39
==========================================
Hits 4691 4691
- Misses 5569 5608 +39
Partials 78 78
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We unified the exported function name across the httpmetrics, httplog
and httptracer middleware. They all export a Handler function which can
be used in the router.
The logging and tracing middleware also catchs panics now to write a log
line / create a span.
Besides that we also fixed a small bug caused by the notification
drawer, introduced in #389. Because of the notification drawer the
drawer in the PageSectionContent component wasn't using it's full height
anymore, which caused problems for the select boxes in the toolbar and
the pages showing graphs via cytoscape. This should be fixed now.