Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Delete all cookies on signout #421

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

ricoberger
Copy link
Member

Until now we only deleted the main cookie when the user clicks the
signout button. This is now changed so that all cookies are deleted.
This means that also the cookies generated by plugins are deleted when
they are starting with "kobs".

Until now we only deleted the main cookie when the user clicks the
signout button. This is now changed so that all cookies are deleted.
This means that also the cookies generated by plugins are deleted when
they are starting with "kobs".
@ricoberger ricoberger force-pushed the app-delete-all-cookies-on-signout branch from 8599fe9 to fba9a98 Compare August 27, 2022 11:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #421 (fba9a98) into main (3a1e4ed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   45.60%   45.61%   +0.01%     
==========================================
  Files         139      139              
  Lines       11888    11892       +4     
==========================================
+ Hits         5421     5425       +4     
  Misses       6328     6328              
  Partials      139      139              
Impacted Files Coverage Δ
pkg/hub/auth/auth.go 72.58% <100.00%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ricoberger ricoberger merged commit eae15fa into main Aug 27, 2022
@ricoberger ricoberger deleted the app-delete-all-cookies-on-signout branch August 27, 2022 11:18
@ricoberger ricoberger added the changelog: changed Something was changed or updated label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: changed Something was changed or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants