Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to .NET 8 and enable AOT compilation #57

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

harrison314
Copy link

Pull request contains:

  • migration to .NET 8.0,
  • Enabling AOT compilation for .NET 8.0 - it was enough to modify one JSON serialization and deserialization.

@koculu
Copy link
Owner

koculu commented Jun 14, 2024

The changes are code-wise acceptable, but there is significant slowness reproducible in the unit tests. This appears to be related to file I/O modifications. Testing was conducted on Windows using .NET 8.0, where the issue was observed. .NET 7.0 works fine.

Issue might be related with these:
dotnet/runtime#87103
or
dotnet/runtime#89100

@koculu
Copy link
Owner

koculu commented Jun 14, 2024

@koculu koculu merged commit 7b331a8 into koculu:main Jun 14, 2024
1 check passed
@harrison314
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants