Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong share text on farcaster #10201

Merged
merged 10 commits into from
May 7, 2024
Merged

fix: Wrong share text on farcaster #10201

merged 10 commits into from
May 7, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented May 3, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

@hassnian hassnian requested a review from a team as a code owner May 3, 2024 09:36
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team May 3, 2024 09:36
Copy link

netlify bot commented May 3, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 37577c6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/663a23a0cfd07c0008072cb7
😎 Deploy Preview https://deploy-preview-10201--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented May 3, 2024

can we ditch the total number of pieces on the share text? at least for me its a bit confusing wdyt

@prury prury added S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-resolve-merge-conflicts-🤝 labels May 3, 2024
@hassnian
Copy link
Contributor Author

hassnian commented May 4, 2024

can we ditch the total number of pieces on the share text? at least for me its a bit confusing wdyt

updated

CleanShot 2024-05-04 at 11 23 50@2x

locales/en.json Outdated Show resolved Hide resolved
@hassnian hassnian requested a review from exezbcz May 6, 2024 12:08
@prury prury removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-resolve-merge-conflicts-🤝 labels May 6, 2024
@prury
Copy link
Member

prury commented May 6, 2024

@hassnian i can still see the total collection amount here when minting one:

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 6, 2024
@hassnian
Copy link
Contributor Author

hassnian commented May 6, 2024

@hassnian i can still see the total collection amount here when minting one:

fixed

CleanShot 2024-05-06 at 18 42 21@2x

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels May 6, 2024
Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit 37577c6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added this pull request to the merge queue May 7, 2024
Merged via the queue into kodadot:main with commit 365ae7a May 7, 2024
18 of 19 checks passed
@prury prury deleted the issue-9982 branch May 7, 2024 12:53
@prury prury mentioned this pull request May 7, 2024
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong share text on farcaster
5 participants