Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop creators to artists offchain profiles & base calendar drops #10536

Merged
merged 21 commits into from
Jul 18, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jun 24, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

❗️❗️ Needs https://github.com/kodadot/private-workers/pull/191

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

profile hover card

CleanShot 2024-06-24 at 11 09 39

drop cards

calendar preview modal

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 71658ef
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66790c84f68d6c0008f5fc80
😎 Deploy Preview https://deploy-preview-10536--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bda49de
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6698e593d6adf50008b3913e
😎 Deploy Preview https://deploy-preview-10536--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as ready for review June 24, 2024 06:11
@hassnian hassnian requested a review from a team as a code owner June 24, 2024 06:11
@hassnian hassnian requested review from vikiival and Jarsen136 and removed request for a team June 24, 2024 06:11
@Jarsen136
Copy link
Contributor

I don't know if the PR solves the issue. From the description of the original issue, it suppose to show the real artist of the drop. We may need a new field for every drop to customise the artist address.

image

@hassnian
Copy link
Contributor Author

I don't know if the PR solves the issue. From the description of the original issue, it suppose to show the real artist of the drop. We may need a new field for every drop to customise the artist address.

added new field artist_address https://github.com/kodadot/private-workers/pull/189

should we hide the created by if artist_address is not provided , or should we fallback on the collection currentOwner

cc @exezbcz

@exezbcz
Copy link
Member

exezbcz commented Jun 24, 2024

should we hide the created by if artist_address is not provided , or should we fallback on the collection currentOwner

we will make sure artist always drop their address, but yeah, some mechanism of hiding could be nice

@exezbcz
Copy link
Member

exezbcz commented Jun 24, 2024

@prury prury added the S-external-resource-needed PR needs a worker to be merged/deployed, a enviroment variable, a API key or any external resource label Jun 24, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Jun 25, 2024

should we hide the created by if artist_address is not provided , or should we fallback on the collection currentOwner

we will make sure artist always drop their address, but yeah, some mechanism of hiding could be nice

done

the list of the artists is here: kodadot/ops-internal#1718 (comment)

once the worker is deployed @JustLuuuu can update each drop and add the creator field

@hassnian hassnian changed the title feat: Switch drop creators to artists offchain profiles (created by) feat: Switch drop creators to artists offchain profiles Jun 25, 2024
@hassnian hassnian marked this pull request as draft June 25, 2024 03:56
@hassnian hassnian marked this pull request as ready for review June 25, 2024 09:39
@hassnian hassnian requested a review from Jarsen136 June 25, 2024 09:39
@hassnian
Copy link
Contributor Author

@Jarsen136 added #10533 pls re-review

thanks

@hassnian hassnian removed the S-external-resource-needed PR needs a worker to be merged/deployed, a enviroment variable, a API key or any external resource label Jun 25, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Jul 3, 2024

cc @hassnian

none of the drops have the creator field updated

cc @JustLuuuu

https://fxart.kodadot.workers.dev/drops

CleanShot 2024-07-03 at 11 12 39@2x

@hassnian hassnian mentioned this pull request Jul 3, 2024
6 tasks
@vikiival
Copy link
Member

vikiival commented Jul 3, 2024

For others @JustLuuuu has to chime in

{
  "data": {
    "collectionEntities": [
      {
        "id": "52",
        "name": "Whirls",
        "recipient": "1L2xstToYKYE3m7R2qLM8MMpGQNmioSkMpx39QcxQucgnNZ"
      },
      {
        "id": "116",
        "name": "Shapes",
        "recipient": null
      },
      {
        "id": "118",
        "name": "Packing",
        "recipient": null
      },
      {
        "id": "120",
        "name": "Aurora",
        "recipient": null
      },
      {
        "id": "123",
        "name": "Aeroloom",
        "recipient": null
      },
      {
        "id": "115",
        "name": "Tilescapes",
        "recipient": "158mjiYukLQPQwz7fReGuxofQg7ssUP4zaZXVukiyDKiqEdL"
      },
      {
        "id": "121",
        "name": "Electronik",
        "recipient": null
      },
      {
        "id": "158",
        "name": "Under the Microscope",
        "recipient": "0x313373557474396555445932433174637150596433384473625378347a37785a4a3735445667686a5053585639316e66"
      },
      {
        "id": "130",
        "name": "Enough",
        "recipient": "13DgGuPvoJgtgtARyATbAEjjQWtepnC8mBjrEgzWYRSTS5mN"
      },
      {
        "id": "134",
        "name": "memoverse",
        "recipient": "123ZjciTXEfgJmQFCqhCqwwYMe6EzbFASA5t2r8nBZXbkhen"
      },
      {
        "id": "127",
        "name": ".hdd",
        "recipient": "1VshyWpZUt8mgtWKgv9pgj8Gin99Wg5PCaDL3iCABixQbUP"
      },
      {
        "id": "112",
        "name": "Convergente",
        "recipient": null
      },
      {
        "id": "76",
        "name": "Assemblies",
        "recipient": "14zMpLStFuyTSmWY4rmGRMSaneTpe5Z425ZDYdSuABoYmejW"
      },
      {
        "id": "152",
        "name": "xest",
        "recipient": "12uQawLwd83igjibocdM75qCN2GzVW8oLPaXaaUeBG9hvz3s"
      },
      {
        "id": "106",
        "name": "Refraction",
        "recipient": "13DVkU7wKdGyY5X53KzQaQhZj1EcR6CmZpjKLkknjcnhBWd7"
      },
      {
        "id": "95",
        "name": "Echo",
        "recipient": "16dDquvnAbg3LHohdJHDaB5t5Mx6NFA2afNiCm9tEoXcR8YM"
      },
      {
        "id": "77",
        "name": ".cpu",
        "recipient": "1VshyWpZUt8mgtWKgv9pgj8Gin99Wg5PCaDL3iCABixQbUP"
      },
      {
        "id": "99",
        "name": "LEADLIGHT",
        "recipient": "15kNtZhj6Wrknr8Qx2MVZacYLyorFrXLHy72FKBjuqfi4i67"
      },
      {
        "id": "91",
        "name": "SailWings",
        "recipient": "15XwKYp5BDpW18xKqPynnuggZhxsWG3sWzKQYave8UErz2rh"
      },
      {
        "id": "51",
        "name": "Chroma Lattice",
        "recipient": "139hEH4Mq9NM2AcDrY9PBZc4KRcBVsaRhAnnBNLZd5gffLgf"
      },
      {
        "id": "63",
        "name": "Genera",
        "recipient": null
      },
      {
        "id": "46",
        "name": "Snowflakes",
        "recipient": null
      },
      {
        "id": "108",
        "name": "Motifs",
        "recipient": null
      },
      {
        "id": "50",
        "name": ".motherboard",
        "recipient": null
      },
      {
        "id": "49",
        "name": "Wall Street Art",
        "recipient": "15Q7VywFCB9o6TBGBY3YJ8xWTVR22EVdRMh153FQMgAattbG"
      },
      {
        "id": "87",
        "name": "Florist",
        "recipient": null
      },
      {
        "id": "66",
        "name": "Split",
        "recipient": "1nmjxYxgXyay2YABPhUrP7HhvyKgBUqSd2R2LKE77eRAMWV"
      },
      {
        "id": "82",
        "name": "Alchemy",
        "recipient": null
      },
      {
        "id": "38",
        "name": "Pare1d0scope",
        "recipient": "1RWmphfVQAwfGAizAqy6ymaTvoc8rknHji6As1YxUWSGpta"
      },
      {
        "id": "60",
        "name": "Christmas City",
        "recipient": null
      },
      {
        "id": "40",
        "name": "Swirls",
        "recipient": null
      }
    ]
  }
}

@JustLuuuu
Copy link
Member

@vikiival - added to profiles that were available

@hassnian
Copy link
Contributor Author

hassnian commented Jul 5, 2024

@exezbcz ready to test

CleanShot 2024-07-05 at 09 57 09@2x

CleanShot 2024-07-05 at 09 58 23@2x

@hassnian hassnian removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 11, 2024
@exezbcz
Copy link
Member

exezbcz commented Jul 11, 2024

image

dark mode

Uploading image.png…

please could you switch the icons to white in dark mode

@vikiival
Copy link
Member

cc @hassnian

@vikiival vikiival added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 13, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Jul 13, 2024

added dark mode

saw icons come from iconify we should integrate this icons if we use them more

ref:

composables/useIcon.ts Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

@hassnian pls resolve issues

@vikiival vikiival added S-resolve-merge-conflicts-🤝 and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 16, 2024
@vikiival
Copy link
Member

cc @hassnian

@hassnian
Copy link
Contributor Author

cc @hassnian

done

Copy link

codeclimate bot commented Jul 18, 2024

Code Climate has analyzed commit bda49de and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@vikiival vikiival enabled auto-merge July 18, 2024 09:53
@vikiival vikiival added this pull request to the merge queue Jul 18, 2024
Merged via the queue into kodadot:main with commit a567940 Jul 18, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants