Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mass transfer feature #11096

Merged
merged 33 commits into from
Oct 22, 2024
Merged

feat: Mass transfer feature #11096

merged 33 commits into from
Oct 22, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 9, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

mass nft transfer should work

reused a lot of the listing cart code , will create a separate pr after this is merged, since now listingCart has multiple uses will refactor it accordingly , I think that It's going to be more manageable reviewing and testing wise

@JustLuuuu could you test?

Needs Design check

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-10-09 at 15 23 45@2x

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cf05380
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67163775aeaa660008aefc0c
😎 Deploy Preview https://deploy-preview-11096--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

vikiival commented Oct 10, 2024

'listVisible' is defined but never used. Allowed unused vars must match /^_/u.

Coplitot:

This pull request includes significant updates to the item transfer process, modal components, and listing cart functionality. The most important changes involve restructuring the ItemTransferModal.vue component, introducing new components for handling multiple and single item transfers, and enhancing the listing cart component with tooltips and improved button functionality.

Item Transfer Enhancements:

Listing Cart Improvements:

Other Component Updates:

@hassnian hassnian marked this pull request as ready for review October 11, 2024 07:29
@hassnian hassnian requested a review from a team as a code owner October 11, 2024 07:29
@hassnian hassnian removed the request for review from a team October 11, 2024 07:29
@JustLuuuu
Copy link
Member

Just tested. Works fine for me:

I have one question: when I used the generic Polkadot address (5CRxWu1z86Z9o9LGjv2QNXkxKQzRe4e29YYzdnnsQA3qesZb) I got this popup:
Screenshot 2024-10-11 at 12 44 30

Solution

Can we just change the text to say: Please use your DOT address? Or something more user friendly? This was a bit confusing.

Also, why don't we support generic addresses here?

@hassnian
Copy link
Contributor Author

Just tested. Works fine for me:

I have one question: when I used the generic Polkadot address (5CRxWu1z86Z9o9LGjv2QNXkxKQzRe4e29YYzdnnsQA3qesZb) I got this popup: Screenshot 2024-10-11 at 12 44 30

Solution

Can we just change the text to say: Please use your DOT address? Or something more user friendly? This was a bit confusing.

Also, why don't we support generic addresses here?

fixed

CleanShot 2024-10-12 at 11 38 47

Copy link

sonarcloud bot commented Oct 21, 2024

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and WFM

@JustLuuuu
Copy link
Member

wfm

@vikiival vikiival added this pull request to the merge queue Oct 22, 2024
Merged via the queue into kodadot:main with commit 6fd77d3 Oct 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass transfer feature Remove items code duplication between stores
4 participants