Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2223): passion feed for stats #3101

Merged
merged 16 commits into from
Jun 23, 2022

Conversation

KngZhi
Copy link
Contributor

@KngZhi KngZhi commented Jun 3, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes Passion feed for spotlight & series #2223

  • Requires deployment <rubick/magick_issue>

  • feat: spotlight passion query

  • feat: passion switch for spotlight

  • refactor: remove unused code and add i18

  • feat: passion list mixin

  • feat: add passionListMixin

  • feat: passion filter on series

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@KngZhi KngZhi requested a review from a team as a code owner June 3, 2022 15:58
@KngZhi KngZhi requested review from prachi00 and removed request for a team June 3, 2022 15:58
@kodabot
Copy link
Collaborator

kodabot commented Jun 3, 2022

SUCCESS @KngZhi PR for issue #2223 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 3, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit e836f31
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62b4a067d6dad70008cfe9f0
😎 Deploy Preview https://deploy-preview-3101--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KngZhi
Copy link
Contributor Author

KngZhi commented Jun 3, 2022

rely on kodadot/rubick#92

@vikiival
Copy link
Member

vikiival commented Jun 3, 2022

You have good day today
🦑 Releasing the Squid at kodadot/rubick@91f590d

@KngZhi
Copy link
Contributor Author

KngZhi commented Jun 3, 2022

🤣 lucky day. but can we wait for a moment.

@KngZhi
Copy link
Contributor Author

KngZhi commented Jun 3, 2022

You have good day today 🦑 Releasing the Squid at kodadot/rubick@91f590d

I need to add a field for series resolver emoteCount

@vikiival
Copy link
Member

vikiival commented Jun 3, 2022

@KngZhi
Copy link
Contributor Author

KngZhi commented Jun 3, 2022

there is already emote count :D https://github.com/kodadot/rubick/blob/68f8d6ee648bb1e1562fce9a1a4c90f5b3f39363/src/mappings/utils/cache.ts

for resolver, not cache. I will submit it now. I will not use the series but seriesInsightTable query for data-range feature. 😄

@prachi00
Copy link
Member

prachi00 commented Jun 7, 2022

LGTM

@prachi00 prachi00 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 7, 2022
@prachi00
Copy link
Member

Screen Shot 2022-06-21 at 1 06 26 PM

Screen Shot 2022-06-21 at 1 05 15 PM

@KngZhi so I was doing a final testing on this one and when you click on the passion feed toggle, the api is giving error

@vikiival
Copy link
Member

final testing on this one and when you click on the passion feed toggle, the api is giving error

Looks like bad query

@KngZhi
Copy link
Contributor Author

KngZhi commented Jun 22, 2022

cause ids is empty arrary. I will check this.

@KngZhi KngZhi requested a review from prachi00 June 22, 2022 12:51
@prachi00
Copy link
Member

LGTM

@prachi00
Copy link
Member

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Jun 23, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 52.86 USD/KSM ~ 1.892 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0x98f5c1f8b4a31a2e601caf207648abf00d3e06de25e8a3fda0d4456391d27f19

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 23, 2022
@prachi00 prachi00 merged commit a4c84f6 into kodadot:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passion feed for spotlight & series
5 participants