Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the appearance when cancelling a transaction #3636

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Change the appearance when cancelling a transaction #3636

merged 3 commits into from
Aug 1, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested review from a team as code owners July 31, 2022 14:08
@Jarsen136 Jarsen136 requested review from prachi00 and JustLuuuu and removed request for a team July 31, 2022 14:08
@kodabot
Copy link
Collaborator

kodabot commented Jul 31, 2022

SUCCESS @Jarsen136 PR for issue #3635 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 31, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 5e9f0db
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62e7d19d01d7b90008bb6dba
😎 Deploy Preview https://deploy-preview-3636--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vikiival
vikiival reviewed Jul 31, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few notes:

  • please do not use sentences as the translation keys
    "Transaction was cancelled" -> general.tx.cancelled

@prachi00 prachi00 added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 31, 2022
JustLuuuu
JustLuuuu approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@JustLuuuu JustLuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@vikiival vikiival enabled auto-merge August 1, 2022 13:13
@vikiival vikiival merged commit ad16f29 into kodadot:main Aug 1, 2022
@Jarsen136
Copy link
Contributor Author

pay 50

@yangwao
Copy link
Member

yangwao commented Aug 3, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 61.02 USD/KSM ~ 0.819 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xc5bc67ce8f100d7f58985a99b7f0fd1d4884fbc7937e177243a0d577d222bf0d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 3, 2022
@yangwao
Copy link
Member

yangwao commented Aug 3, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 61.02 USD/KSM ~ 0.819 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x6b036a949f03ed90b25374f0c6668bb45c8f8879373be70a24802859c3f5a7d1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Aug 3, 2022 •
edited
Loading

Oh, my bad 😥 I thought the transfer had failed, so I resent the command.

I have sent back 0.819 ksm to G29NScLSew5zqwmJAPupvJWDCDkpxKUhDnMeVdD2BBcnHar
tx: 0x175d1b5ffca3048d93ee5f5065f6cd5764a7cefabe0c06a5e9e4cec18c99fd56

@petersopko
Copy link
Contributor

@yangwao may be time to introduce the limit on sending payouts? i.e. people shouldn't be able to pay themselves?

@vikiival
Copy link
Member

vikiival commented Aug 3, 2022

people shouldn't be able to pay themselves?

this could be a nice feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival left review comments

@prachi00 prachi00 prachi00 approved these changes

@JustLuuuu JustLuuuu JustLuuuu approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the appearance when cancelling a transaction
7 participants
@Jarsen136 @kodabot @yangwao @petersopko @vikiival @prachi00 @JustLuuuu