Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Carousel - Move from rmrk folder #3819

Merged
merged 16 commits into from
Aug 27, 2022

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged the recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Aug 23, 2022

SUCCESS @preschian PR for issue #3773 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 23, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dfc5493
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6308e8f6ec486b00089e4d2c
😎 Deploy Preview https://deploy-preview-3819--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review August 23, 2022 19:32
@preschian preschian requested review from a team as code owners August 23, 2022 19:32
@preschian preschian requested review from prachi00, damskyftw and Jarsen136 and removed request for a team and damskyftw August 23, 2022 19:32
@preschian
Copy link
Member Author

is commented passionFeed safe to remove?

this PR only groups carousel-related components into the same folder. will open separate PR for migration to compose API

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

is commented passionFeed safe to remove?

actually we would like to reintroduce it again hmm 😅

@preschian
Copy link
Member Author

actually we would like to reintroduce it again hmm 😅

added back that again 👍

@prachi00 prachi00 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 23, 2022
@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 25, 2022
@yangwao
Copy link
Member

yangwao commented Aug 25, 2022

Tests seem failed 🤔
Let's try update branch

@codeclimate
Copy link

codeclimate bot commented Aug 26, 2022

Code Climate has analyzed commit dfc5493 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Aug 27, 2022

pay 100

@yangwao yangwao merged commit 21639d1 into kodadot:main Aug 27, 2022
@yangwao
Copy link
Member

yangwao commented Aug 27, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 45.54 USD/KSM ~ 2.196 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x5ece7e7267d0f79e24e71953950b52d03ae8b944dbe678c54abc10bf02bd1b9c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 27, 2022
@preschian preschian deleted the refactor-carousels branch August 27, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Carousel - Move from rmrk folder
6 participants