Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Network is not clickable at certain width #4187

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix: Network is not clickable at certain width #4187

merged 2 commits into from
Oct 27, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 27, 2022 01:55
@Jarsen136 Jarsen136 requested review from prachi00 and removed request for a team October 27, 2022 01:55
@kodabot
Copy link
Collaborator

kodabot commented Oct 27, 2022

SUCCESS @Jarsen136 PR for issue #4186 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 27, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 7d54eff
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/635a869db0b6160009c356cf
😎 Deploy Preview https://deploy-preview-4187--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00 prachi00 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 27, 2022
roiLeo
roiLeo approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

@roiLeo
Copy link
Contributor

roiLeo commented Oct 27, 2022

pay 20

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2022

Code Climate has analyzed commit 7d54eff and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo enabled auto-merge October 27, 2022 13:25
@yangwao
Copy link
Member

yangwao commented Oct 27, 2022

😍 Perfect, I’ve sent the payout
💵 $20 @ 36.15 USD/KSM ~ 0.553 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xb536e19611ac38ad8bb83c4609e08ca9805277ea80773e28d3d50fe79a2600cc

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 27, 2022
@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 27, 2022
@roiLeo roiLeo merged commit 9459512 into kodadot:main Oct 27, 2022
@Jarsen136
Copy link
Contributor Author

😍 Perfect, I’ve sent the payout 💵 $20 @ 36.15 USD/KSM ~ 0.553 $KSM 🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG 🔗 0xb536e19611ac38ad8bb83c4609e08ca9805277ea80773e28d3d50fe79a2600cc

🪅 Let’s grab another issue and get rewarded! 🪄 github.com/kodadot/nft-gallery/issues

Hey, @yangwao the transaction failed due to InsufficientBalance. 👀

@Jarsen136
Copy link
Contributor Author

hey, @yangwao , could you pls take a look at this?

And issue 4188 also has the same problem.

@yangwao yangwao removed the paid pull-request has been paid label Jan 8, 2023
@yangwao
Copy link
Member

yangwao commented Jan 8, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Jan 8, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 24.65 USD/KSM ~ 0.811 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xe5009f4044707058618d9eb0e5447f902ad4dedee5fbdf5428417a480206f8e5

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prachi00 prachi00 prachi00 approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network is not clickable at certain width
5 participants
@Jarsen136 @kodabot @roiLeo @yangwao @prachi00