teleport KSM token between Kusama and Basilisk #4297

Jarsen136 · 2022-11-10T05:46:35Z

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes Implement teleport KSM token from Kusama to Basilisk #4035
Requires deployment <>

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </bsx/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

currently, the url for teleport is /teleport-bridge

kodabot · 2022-11-10T05:46:39Z

SUCCESS @Jarsen136 PR for issue #4035 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2022-11-10T05:46:40Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`6b2311b`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/637cdde8f6f14d0009cf0a22
😎 Deploy Preview	https://deploy-preview-4297--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Jarsen136 · 2022-11-10T05:57:55Z

Work in progress:

setup teleport page on kodadot, according to https://github.com/paraspell/ui
teleport ksm token from Kusama to Basilisk

I have send 1 ksm from Kusama to Basilisk on teleport page. https://kusama.subscan.io/xcm_message/kusama-350df3d577486e2054b580f0065c872b4b4d693b
Still waiting for the confirmation at Basilisk network.

teleport ksm token from Basilisk to Kusama
refactor code of teleport component
UI redesign teleport

yangwao · 2022-11-10T17:46:27Z

Still waiting for the confirmation at Basilisk network.

Basilisk is bricked for now and won't work for like 5-6 days for sure :|

BUT we can test it against

Statemine (live net)
Rococo at SNEK (Basilisk testnet), probably @vikiival can send you some testnet tokens there

Jarsen136 · 2022-11-11T01:50:03Z

BUT we can test it against

Statemine (live net)

Rococo at SNEK (Basilisk testnet), probably @vikiival can send you some testnet tokens there

Oh, that would be better.
My Basilisk test address is bXk6PXHj9NnYkiZ45ETrq4iLiozW8a4khe8ZmqDkdbLJNNMaE

yangwao · 2022-11-13T13:04:14Z

Once merge, we can test this one

Revert ":snake: Stuck Snek" #4326

…sue-4035

yangwao · 2022-11-16T08:19:46Z

It should working now? 👀

lmk whenever we can test & merge this 😎

Jarsen136 · 2022-11-17T06:24:02Z

Teleport bridge path: https://deploy-preview-4297--koda-nuxt.netlify.app/teleport-bridge

setup teleport page on kodadot, according to https://github.com/paraspell/ui
refactor code of teleport component

teleport ksm token from Kusama to Basilisk (✅ Tested)

Teleport Steps:

switch to rmrk network
input the bsx recipient address
send transaction

teleport ksm token from Basilisk to Kusama

Teleport Steps:

switch to bsx network
input the ksm recipient address
send transaction

I have tried many times to test the functionality that on Basilisk. However, it's hard for me to connect with the Basilisk websocket network.

Could anyone do a teleport test from Kusama to Basilisk?

components/teleport/Teleport.vue

Jarsen136 · 2022-11-17T17:48:41Z

teleport ksm token from Basilisk to Kusama

Teleport Steps:

switch to bsx network

input the ksm recipient address

send transaction

I have tried many times to test the functionality that on Basilisk. However, it's hard for me to connect with the Basilisk websocket network.

I have found out why it does not work properly when I teleport ksm from Basilisk.

As we could see at @paraspell/sdk here : https://github.com/paraspell/sdk/blob/7fc8b1e87033ac4e0de024f81d52f6558474531e/src/pallets/xTokens/transfer.ts#L5

Function transferParaToRelay does not prepare the result for Basilisk.

So, I guess we should fulfill the function transferParaToRelay for Basilisk first. 🤔 WDYT @vikiival

…sue-4035

codeclimate

The PR diff size of 14635 lines exceeds the maximum allowed for the inline comments feature.

vikiival · 2022-11-21T10:54:01Z

However, the network on Basilisk node seems not that stable.

what does that mean?

Jarsen136 · 2022-11-21T11:01:20Z

However, the network on Basilisk node seems not that stable.

what does that mean?

I have to wait for a long time to connect to Basilisk rpc node when I want to teleport token. I'm not sure it's related to my own network or not. It really kills my time : )

dudo50 · 2022-11-21T12:23:56Z

@Jarsen136 Transfer Basilisk to Relay chain does not work because you use wrong version of sdk, currently version in main branch is suited for localhost use with UI only. However if you switch to beta-pre-release branch I think you will find what you were searching for :)..
If you have any questions feel free to contact me or tag me here.

Jarsen136 · 2022-11-21T13:32:52Z

@Jarsen136 Transfer Basilisk to Relay chain does not work because you use wrong version of sdk, currently version in main branch is suited for localhost use with UI only. However if you switch to beta-pre-release branch I think you will find what you were searching for :).. If you have any questions feel free to contact me or tag me here.

Hey, @dudo50 thanks for your answer. The beta-pre-release branch would help to transfer tokens from Basilisk. However, the latest version 0.0.11 for SDK is built from the main branch. So, I guess there is no specific released version of SDK that could support transferring tokens from Basilisk, for now. Correct me if i'm wrong.

For now, I write the transfer function call code without using any SDK. If the latest version of @paraspell/sdk is released in the future, I would switch to using the SDK to support transfer tokens on more network

dudo50 · 2022-11-21T13:37:07Z

@Jarsen136 there is actually it is called 0.0.11.alpha I believe, you can check it on npm.. It supports Basilisk and Kusama transfers out of the box. However I respect your decision, I would like to encourage you to check it anyways so you can see how to construct calls you seek if there is something you still need to implement :)

Jarsen136 · 2022-11-21T13:49:32Z

@Jarsen136 there is actually it is called 0.0.11.alpha I believe, you can check it on npm.. It supports Basilisk and Kusama transfers out of the box. However I respect your decision, I would like to encourage you to check it anyways so you can see how to construct calls you seek if there is something you still need to implement :)

Thanks for correcting me : ) I will use this alpha version of SDK to help to build the teleport function. I think it would do better.

dudo50 · 2022-11-21T14:50:36Z

No worries @Jarsen136, it is still under construction so some things might not be clear right away. We plan on converting it into a builder pattern soon to make things as intuitive as possible.. If you have any questions feel free to tag me :)..

Jarsen136 · 2022-11-21T15:58:34Z

After many times of testing, I think the functionality is good for testing now. @yangwao

https://deploy-preview-4297--koda-nuxt.netlify.app/teleport-bridge

yangwao · 2022-11-21T15:59:52Z

i was randomly checking this pr, when was draft and suddenly green!
can test and let you know

yangwao · 2022-11-21T16:05:06Z

@Jarsen136, maybe adding teleport-bridge to dropdown?

I would add it under Transfer for now :)

once this is merged,
someone can take

Revamp XCM Teleport + Assets #4119
to do styling :)

Jarsen136 · 2022-11-21T16:40:28Z

@Jarsen136, maybe adding teleport-bridge to dropdown?

I would add it under Transfer for now :)

Done.

vikiival

Please use already made components

vikiival · 2022-11-21T16:44:58Z

components/teleport/Teleport.vue

+      </b-select>
+    </b-field>
+
+    <b-field


AccountInput cries in the corner

vikiival · 2022-11-21T16:45:11Z

components/teleport/Teleport.vue

+      </b-select>
+    </b-field>
+
+    <b-field class="" label-position="inside" label="Input currency amount">


BalanceInput cries in the corner

BalanceInput

vikiival · 2022-11-21T16:45:34Z

components/teleport/Teleport.vue

+        :step="0.0001"></b-input>
+    </b-field>
+
+    <b-button


SubmitButton cries in third corner

vikiival · 2022-11-21T16:45:56Z

components/teleport/Teleport.vue

+import { ApiPromise, WsProvider } from '@polkadot/api'
+import { web3Enable } from '@polkadot/extension-dapp'
+import '@polkadot/api-augment'
+import { toDefaultAddress } from '@/utils/account'
+import { getAddress } from '@/utils/extension'
+import { Chain, ChainIdMap } from '@/utils/teleport'
+import { notificationTypes, showNotification } from '@/utils/notification'
+import useAuth from '@/composables/useAuth'
+import Loader from '@/components/shared/Loader.vue'
+import * as paraspell from '@paraspell/sdk'


Plese use sub-api :)

I'm afraid that it could not use sub-api. Because If I want to teleport tokens from Kusama, I need to use ApiPromise of kusama. On the other hand, I would use ApiPromise of basilisk.

And sub-api would only return the API endpoint according to the current prefix. 👀

kodadot/packages#78

vikiival · 2022-11-21T16:46:24Z

components/teleport/Teleport.vue

+  const injector = await getAddress(toDefaultAddress(address))
+
+  if (fromChain.value === Chain.KUSAMA) {
+    const wsProvider = new WsProvider('wss://public-rpc.pinknode.io/kusama')
+    const apiKusama = await ApiPromise.create({ provider: wsProvider })
+
+    const promise = paraspell.xTokens.transferRelayToPara(
+      apiKusama,
+      ChainIdMap[Chain.BASILISK],
+      amount.value * 1e12,
+      toAddress.value
+    )
+
+    promise
+      .signAndSend(address, { signer: injector.signer }, transactionHandler)
+      .catch(errorHandler)


transactionExecutor.ts

Used txCb utils function

codeclimate · 2022-11-22T14:34:47Z

Code Climate has analyzed commit 6b2311b and detected 0 issues on this pull request.

View more on Code Climate.

yangwao · 2022-11-23T13:48:08Z

I don't have my keys with me rn, so I believe it has worked!

pay 150 USD

yangwao · 2022-11-23T13:48:22Z

😍 Perfect, I’ve sent the payout
💵 $150 @ 25.92 USD/KSM ~ 5.787 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x09332075fa27f7301474f43751818f0e80f7518a5cea7bb46fdc8a85e3909a6a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

yangwao · 2022-11-23T13:51:07Z

Let's now crack on

Revamp XCM Teleport + Assets #4119

feat: setup teleport

546bf8f

Jarsen136 requested a review from a team as a code owner November 10, 2022 05:46

Jarsen136 requested review from prachi00 and removed request for a team November 10, 2022 05:46

Jarsen136 marked this pull request as draft November 10, 2022 05:46

feat: setup teleport

e0d4404

yangwao added the A-basilisk issues related to basilisk parachain label Nov 11, 2022

Jarsen136 added 4 commits November 15, 2022 00:44

feat: teleport bridge

abac680

Merge branch 'issue-4035' of github.com:Jarsen136/nft-gallery into is…

3637586

…sue-4035

refactor: teleport component

576d579

fix: teleport from basilisk

6eb048a

Jarsen136 added 3 commits November 17, 2022 01:18

fix: teleport from basilisk

3e2088d

refactor: teleport utils

c9e024a

Merge branch 'main' into issue-4035

b99f384

preschian reviewed Nov 17, 2022

View reviewed changes

components/teleport/Teleport.vue Outdated Show resolved Hide resolved

refactor: composition API for teleport

70f71e4

Jarsen136 and others added 4 commits November 21, 2022 09:30

fix: teleport ksm from basilisk

a58e908

Merge branch 'main' into issue-4035

10aabe8

feat: teleport ksm

ac36089

Merge branch 'issue-4035' of github.com:Jarsen136/nft-gallery into is…

7c1dfed

…sue-4035

codeclimate bot reviewed Nov 21, 2022

View reviewed changes

Jarsen136 changed the title ~~WIP: teleport KSM token between Kusama and Basilisk~~ teleport KSM token between Kusama and Basilisk Nov 21, 2022

feat: teleport ksm

dcae9d9

Jarsen136 marked this pull request as ready for review November 21, 2022 15:54

yangwao mentioned this pull request Nov 21, 2022

Revamp XCM Teleport + Assets #4119

Closed

dudo50 mentioned this pull request Nov 21, 2022

Contact Kodadot before new version rolls out paraspell/xcm-tools#10

Closed

feat: add teleport bridge to navbar dropdown

882dd0a

vikiival mentioned this pull request Nov 21, 2022

Create NeoSelect #4363

Closed

vikiival requested changes Nov 21, 2022

View reviewed changes

Jarsen136 added 2 commits November 22, 2022 22:14

refactor: reuse common component

1dabb86

Merge branch 'main' into issue-4035

e07e32a

Jarsen136 requested a review from vikiival November 22, 2022 14:26

fix: update pnpm lock

6b2311b

yangwao mentioned this pull request Nov 23, 2022

sub-api teleport ready kodadot/packages#78

Closed

yangwao added the paid pull-request has been paid label Nov 23, 2022

yangwao merged commit 2ac5923 into kodadot:main Nov 23, 2022

teleport KSM token between Kusama and Basilisk #4297

teleport KSM token between Kusama and Basilisk #4297

Conversation

Jarsen136 commented Nov 10, 2022

PR Type

Context

Before submitting pull request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot 📸

kodabot commented Nov 10, 2022

netlify bot commented Nov 10, 2022 • edited Loading

✅ Deploy Preview for koda-nuxt ready!

Jarsen136 commented Nov 10, 2022

yangwao commented Nov 10, 2022 • edited Loading

Jarsen136 commented Nov 11, 2022

yangwao commented Nov 13, 2022

yangwao commented Nov 16, 2022 • edited Loading

Jarsen136 commented Nov 17, 2022 • edited Loading

Jarsen136 commented Nov 17, 2022

codeclimate bot left a comment

Choose a reason for hiding this comment

vikiival commented Nov 21, 2022

Jarsen136 commented Nov 21, 2022

dudo50 commented Nov 21, 2022

Jarsen136 commented Nov 21, 2022

dudo50 commented Nov 21, 2022

Jarsen136 commented Nov 21, 2022

dudo50 commented Nov 21, 2022 • edited Loading

Jarsen136 commented Nov 21, 2022 • edited Loading

yangwao commented Nov 21, 2022

yangwao commented Nov 21, 2022 • edited Loading

Jarsen136 commented Nov 21, 2022 • edited Loading

vikiival left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeclimate bot commented Nov 22, 2022

yangwao commented Nov 23, 2022

yangwao commented Nov 23, 2022

yangwao commented Nov 23, 2022 • edited Loading

netlify bot commented Nov 10, 2022 •

edited

Loading

yangwao commented Nov 10, 2022 •

edited

Loading

yangwao commented Nov 16, 2022 •

edited

Loading

Jarsen136 commented Nov 17, 2022 •

edited

Loading

dudo50 commented Nov 21, 2022 •

edited

Loading

Jarsen136 commented Nov 21, 2022 •

edited

Loading

yangwao commented Nov 21, 2022 •

edited

Loading

Jarsen136 commented Nov 21, 2022 •

edited

Loading

yangwao commented Nov 23, 2022 •

edited

Loading