Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redesigned Gallery Item live on production #4749

Merged
merged 116 commits into from
Jan 18, 2023
Merged

Make redesigned Gallery Item live on production #4749

merged 116 commits into from
Jan 18, 2023

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Jan 18, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

vikiival and others added 24 commits January 17, 2023 14:37
fix: Description more important than Properties
hotfix: incorrect url prefix on gallery item page
test: enable media component and upgrade cypress
fix: Change description of SEO Cards
feat: Gallery Item Mobile Action Buttons
fix: Wrap markdown in description
@yangwao yangwao requested a review from a team as a code owner January 18, 2023 10:08
@yangwao yangwao requested review from vikiival and Jarsen136 and removed request for a team January 18, 2023 10:08
@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 6cb5a88
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c7c519dcce110008d86fa2
😎 Deploy Preview https://deploy-preview-4749--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao merged commit 2458534 into hyper-jpeg Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants