Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Minimark as subpackages #57

Closed
vikiival opened this issue Oct 12, 2022 · 4 comments · Fixed by #43 or #91
Closed

Export Minimark as subpackages #57

vikiival opened this issue Oct 12, 2022 · 4 comments · Fixed by #43 or #91
Labels
help wanted Extra attention is needed minimark

Comments

@vikiival
Copy link
Member

What is the current solution

currently when someone wants to use minimark she or he will need to export functions like

import { createCollection } from '@kodadot1/minimark'

It is good but we will have V2 #43 soon and I would cause chaos

What I am trying to achieve

that we will have Subpackages

For RMRK v1

import { createCollection } from '@kodadot1/minimark/v1'

For RMRK v2

import { createCollection } from '@kodadot1/minimark/2'

For Common

import { asSystemRemark } from '@kodadot1/minimark/common'

I already hacked something

but it is not ideal and I am missing CommonJS

main...unmark

@vikiival vikiival added minimark help wanted Extra attention is needed labels Oct 12, 2022
@vikiival
Copy link
Member Author

@vikiival
Copy link
Member Author

Finally I have a working version

import { createCollection } from '@kodadot1/minimark/v1'
import { createCollection as createV2 } from '@kodadot1/minimark/v2'

@vikiival
Copy link
Member Author

Still issue in typescript
unjs/ofetch#143

@vikiival vikiival changed the title Help needed: Subpackages Export Minimark as subpackages Oct 17, 2022
vikiival added a commit to KngZhi/packages that referenced this issue Oct 24, 2022
@vikiival vikiival linked a pull request Dec 16, 2022 that will close this issue
8 tasks
@vikiival vikiival mentioned this issue Jan 17, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed minimark
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant