Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

219 direct transfers #237

Merged
merged 3 commits into from
Apr 12, 2023
Merged

219 direct transfers #237

merged 3 commits into from
Apr 12, 2023

Conversation

vikiival
Copy link
Member

  • ⚡ directly nest NFT during mint
  • ⚡ emit send when recipient was there
  • 🐛 bad send interaction if NFT was nested

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

@vikiival vikiival merged commit e9ad306 into main Apr 12, 2023
@vikiival vikiival deleted the 219-direct-transfers branch April 12, 2023 19:54
@vikiival vikiival mentioned this pull request Apr 12, 2023
Closed
@vikiival vikiival added the V2 Implementation of RMRK::2.0.0 label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
V2 Implementation of RMRK::2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mint can directly transfer NFT to recipient
1 participant
@vikiival