feat(exoflex): bump react-native-paper to v3 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcien
force-pushed
the
exo/upgrade-paper
branch
from
0a320cd
to
a08f309
Compare
| </View> | ||
| ); | ||
| function ProgressBar(props: Props) { | ||
| return <PaperProgressBar {...props} />; |
There was a problem hiding this comment.
i'm afraid we'll still won't be able to use Paper's ProgressBar
there is no prop to change the bar radius
darcien
force-pushed
the
exo/upgrade-paper
branch
from
a08f309
to
99c0fe8
Compare
darcien
commented
Oct 29, 2019
| @@ -20,7 +21,9 @@ export default function ProgressBar(props: Props) { | |||
| duration: 500, | |||
| }); | |||
|
|
|||
| let height = (style && style.height) || 8; | |||
| let flattenedStyle = StyleSheet.flatten(style); | |||
There was a problem hiding this comment.
I'm not sure about using flatten in our component, but this is the quick fix.
There was a problem hiding this comment.
I think we could rebase this diff now as #159 has been landed with a fix for this.
oshimayoan
reviewed
Nov 1, 2019
| @@ -76,7 +76,11 @@ function TextInputOutlined( | |||
|
|
|||
| function ErrorIcon(props: { color: string }) { | |||
| return ( | |||
| <IconButton icon="error-outline" style={styles.errorIcon} {...props} /> | |||
| <IconButton | |||
| icon="alert-circle-outline" | |||
There was a problem hiding this comment.
I forgot about RNP v3 is using MaterialCommunityIcons instead of MaterialIcons. Should we consider that a breaking change?
There was a problem hiding this comment.
Definitely, there's also a separate issue about the theme typing that makes this a breaking changes.
Also, like I stated before, I think we should land #158 first. So I think it's unlikely we'll use RNP v3 in exoflex v2.
There was a problem hiding this comment.
I see.
Well, we need to move this one out from Milestone 2.7 to v3 then.
| @@ -2,6 +2,7 @@ import * as Drawer from './Drawer'; | |||
|
|
|||
| export { default as Accordion } from './Accordion'; | |||
| export { default as ActivityIndicator } from './ActivityIndicator'; | |||
| export { default as AnimatedIcon } from './AnimatedIcon'; | |||
darcien
force-pushed
the
exo/upgrade-paper
branch
from
99c0fe8
to
c92a76a
Compare
1 task
oshimayoan
pushed a commit
that referenced
this pull request
Dec 4, 2019
* chore: upgrade react-native-paper * chore: fix missing Props typing * chore: fix missing DeepPartial type * fix: add missing colors to theme * feat: use paper version of progressbar * chore: fix mismatching theme shape for provider * fix: fix invalid icon name * refactor: factor out AnimatedIcon component * chore: bump react-native-paper to 3.1.1 * fix: fix invalid icon name in TimePicker * fix: fix lint error on ProgressBar * fix: fix missing ModalProps from RNP * fix: use merged theme for exoflex theme context * feat: add utility type to omit theme prop * fix: omit theme from Portal props * refactor: use utility type to omit theme
oshimayoan
added a commit
that referenced
this pull request
Dec 6, 2019
* feat(exoflex): avatar component (#185) * feat(exoflex): avatar component feat(exoflex): avatar component * chore(exoflex): avatar example * chore(exoflex): minor fix * test(exoflex): unit tests * fix(exoflex): use readonly for props and add textPreset * chore(exoflex): make example better * fix(exoflex): omit color from Avatar.Text * docs(exoflex): typo fix * docs(exoflex): avatar docs * docs(exoflex): minor fix * feat(exoflex): move automatic fonts loading to theme props (#158) * feat: add source property to font * feat: add getFontsSource helper * feat: deprecate fonts props in provider * feat: skip fonts loading when source is empty * feat: add mergeTheme helper * feat: add lodash.mergewith * feat: replace deepmerge.all with mergeTheme helper * chore: remove deepmerge package * refactor: simplify skip fonts loading logic * feat: deprecate useSystemFonts prop in provider * refactor: rename BuiltInFonts to RubikSourcesMap * docs: update example Provider usage * feat: use only sans-serif for default system fonts * feat(exoflex): bump react-native-paper to v3 (#150) * chore: upgrade react-native-paper * chore: fix missing Props typing * chore: fix missing DeepPartial type * fix: add missing colors to theme * feat: use paper version of progressbar * chore: fix mismatching theme shape for provider * fix: fix invalid icon name * refactor: factor out AnimatedIcon component * chore: bump react-native-paper to 3.1.1 * fix: fix invalid icon name in TimePicker * fix: fix lint error on ProgressBar * fix: fix missing ModalProps from RNP * fix: use merged theme for exoflex theme context * feat: add utility type to omit theme prop * fix: omit theme from Portal props * refactor: use utility type to omit theme * fix(exoflex): resize icon on TimePicker web (#198) * feat(exoflex): add icon to Chip (#199) * feat: add icon to Chip * docs: add example for Chip * docs: update props docs for Chip * docs: update font name for icon * docs: update chip preview * feat(exoflex): add Badge component (#202) * chore(exoflex): add color package * feat(exoflex): create Badge component * docs(exoflex): add Badge examples * docs(exoflex): add docs for Badge * fix(exoflex): omit paper visible prop * test(exoflex): add tests * chore(exoflex): add color type * chore(exoflex): cherry pick fix toast animation regression from #188 * fix(exoflex): fix badge visible animation * feat(exoflex): add textPreset prop * docs(exoflex): update docs * test(exoflex): fix avatar test * chore(exoflex): minor fix * fix(exoflex): minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full error log fromyarn testis available herehttps://gist.github.com/darcien/e63e9645b5e0496cc8aa0c621e663281
Fixed with RNP v3.1.1
We're ready for upgrade! 🎉
Ideally, we should land #158 first before this one.