Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix microsecond precision loss in datetime hydration (kodemore#3) #4

Conversation

stortiz-lifeworks
Copy link
Contributor

Fixes #3

@stortiz-lifeworks stortiz-lifeworks changed the title Fix millisecond precision loss in datetime hydration (kodemore#3) Fix microsecond precision loss in datetime hydration (kodemore#3) Oct 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #4 (7256625) into main (31fb2a3) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   95.79%   95.88%   +0.08%     
==========================================
  Files          26       26              
  Lines        1308     1311       +3     
==========================================
+ Hits         1253     1257       +4     
+ Misses         55       54       -1     
Impacted Files Coverage Δ
tests/test_iso_datetime.py 100.00% <ø> (ø)
chili/iso_datetime.py 90.58% <100.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fb2a3...7256625. Read the comment docs.

@dkraczkowski dkraczkowski merged commit ab8c8c7 into kodemore:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetime hydration loses millisecond precision
3 participants