Improve the file management in generated solutions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
system up to par with the old VS solution)
|
I'm not a cmake expert, but this looks sane to me. |
|
Me neither, but I've used the same approach in https://github.com/kodi-pvr/pvr.vbox/blob/master/CMakeLists.txt and it works fine. The biggest improvement is the ability to bump versions etc. directly in the IDE instead of having to hunt down the file manually. |
ksooo
added a commit
that referenced
this pull request
May 5, 2015
Improve the file management in generated solutions
Glenn-1990
pushed a commit
to Glenn-1990/pvr.hts
that referenced
this pull request
May 18, 2015
Improve the file management in generated solutions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some regression in the usability of the Visual Studio solution after we switched to cmake. This brings it up to par with how it was before.