Implement API function GetStreamTimes & PVR Addon API 5.8.0 #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jalle19
reviewed
Dec 22, 2017
| times->startTime = m_startTime; | ||
| times->ptsStart = 0; | ||
| times->ptsBegin = static_cast<int64_t>(static_cast<double>(m_timeshiftStatus.start / 1000000)) * DVD_TIME_BASE; | ||
| times->ptsEnd = static_cast<int64_t>(static_cast<double>(m_timeshiftStatus.end / 1000000)) * DVD_TIME_BASE; |
There was a problem hiding this comment.
Remember the "Note: start/end mismatch is not a bug. tvh uses inversed naming logic here!" comment
There was a problem hiding this comment.
TBH, I never understood this. As a matter of fact, it's working now - it's carefully runtime tested. Too lazy to think through this, tbh. I take it like I observed it.
There was a problem hiding this comment.
If it works then it's all good, it could be that the hack we had in place is some old stuff that is no longer relevant in newer tvheadend versions.
PVR Addon API 5.8.0: Remove implementation of deprecated API functions GetBufferTime(Start|End), GetPlayingTime, Position(Recorded|Live)Stream, MoveChannel. PVR Addon API 5.8.0: Add support for PVR_CHANNEL_GROUP_MEMBER::iSubChannelNumber"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement API function GetStreamTimes (for tv/radion steam, recordings can be added later - currentyl tvh does not give access to recording times).
Remove implementation of deprecated API functions GetBufferTime(Start|End), GetPlayingTime, POsition(Recorded|Live)Stream, MoveChannel.
Add support for PVR_CHANNEL_GROUP_MEMBER::iSubChannelNumber"
Details: xbmc/xbmc#13228