[cmake] remove usage of kodi-platform #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a specific reason in Kodi that this is being requested? Although I was not aware of this historical reference, after a bit of research I would like to make use of the features in "util/XMLUtils.h" to clean up the tinyxml calls as I touch the code. There may be other useful features that we are missing. |
|
There is no reason to require a library which isn't used. If you want to use it eventually, you can readd it as dependency. |
The pvr.nextpvr binary addon does not use kodi-platform. Remove existing references from CMakeLists.txt and debian/control. Add dependency to libp8-platform-dev because libkodiplatform-dev pulled that dependency in as a side effect. Fix that bug too by adding an explicit dependency. Signed-off-by: Olaf Hering <olaf@aepfle.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pvr.nextpvr binary addon does not use kodi-platform.
Remove existing references from CMakeLists.txt and debian/control.