[Testing Required] update to PVR addon API 5.7.0 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
requested changes
Oct 28, 2017
src/PctvData.cpp
Outdated
| PVR_ERROR Pctv::GetChannelStreamProperties(const PVR_CHANNEL* channel, PVR_NAMED_VALUE* properties, unsigned int* iPropertiesCount) | ||
| { | ||
| std:string strUrl = ""; | ||
| for (unsigned int i = 0; i<m_channels.size(); i++) |
There was a problem hiding this comment.
Could you please insert blank around the <?
There was a problem hiding this comment.
You also might want to look at my comments re. string initialization and 'better' for loop syntax in your other (pvr.filmon) PR. ;-)
|
Fine now, imo. Could you please squash non-jsoncpp stuff to a single commit and we're ready to merge (forget to request that for your other PR, btw ;-) |
remove deprecated functions, implement basic requirements for GetRecordingStreamProperties() and GetChannelStreamProperties() getFormatedErrorMessages() was deprecated in jsoncpp for its replacement getFormattedErrorMessages(). Deprecation was done purely for the typo. No functional change
|
squashed |
|
Why did you close this? |
|
Man, you're even to fast for me... |
|
Fat fingered the comment. Haha |
|
Ready to merge, imo. Shall I hit the button? |
ksooo
approved these changes
Oct 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the addon upto API 5.7.0 compatibility
Removed deprecated methods and stubbed out new ones
Bumped jsoncpp to 0.10.6 and changed to non deprecated getFormattedErrorMessages(). No functional change for this, as the deprecation was done purely because of the type in the function name.
Please note, ive not been able to test functionality at all. If anyone can let me know if the changes work, or need further tweaking. This was a quick attempt to get up and running, so feedback is very appreciated.