Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time offset matrix and remove external XMLTV #226

Merged
merged 5 commits into from Oct 22, 2019

Conversation

phunkyfish
Copy link
Member

@phunkyfish phunkyfish commented Oct 21, 2019

5.4.0
- Fix timezone offset changing kodi time
- remove compat functions as no longer needed
- Remove external xmltv as xmltv supported by vbox

@phunkyfish phunkyfish changed the title [WIP] fix time offset matrix [WIP] fix time offset matrix and remove external XMLTV Oct 21, 2019
@phunkyfish phunkyfish changed the title [WIP] fix time offset matrix and remove external XMLTV Fix time offset matrix and remove external XMLTV Oct 21, 2019
* Android doesn't have timegm() and Windows calls it _mkgmtime()
* Source: http://linux.die.net/man/3/timegm
*/
inline time_t timegm(struct tm *tm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally forgot we had this here. I think this snippet was introduced to fix some Windows issue.

@phunkyfish
Copy link
Member Author

phunkyfish commented Oct 22, 2019

Won't merge until after the weekend as we can test when the hour goes back before releasing this.

EDIT: I think now it may be better to release before the weekend. Maybe better to have more users feedback on the change than just one, otherwise we have to wait 6 months for another DST change.

@phunkyfish phunkyfish merged commit 8076191 into kodi-pvr:Matrix Oct 22, 2019
@phunkyfish phunkyfish deleted the time-offset-fix-matrix branch October 22, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants