Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot crash fix matrix #228

Merged
merged 3 commits into from
Oct 26, 2019
Merged

Conversation

phunkyfish
Copy link
Member

@phunkyfish phunkyfish commented Oct 22, 2019

5.5.0

  • Skip initial EPG load to avoid crash scenario on boot on LibreElec/CoreElec
  • New settings format and settings levels / help text

Same solution is used in pvr,vuplus. The issue is that an EPG load is generated by kodi and also the the addon. These appear to conflict and 2 channels call GetEPGForChannel at the same time. This happens occasionally some hard to capture.

Copy link
Contributor

@Jalle19 Jalle19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksooo do you have any idea what this happens? It seems to be an issue in other addons too. I'm a bit reluctant about adding a hack like this.

README.md Outdated Show resolved Hide resolved
src/client.cpp Show resolved Hide resolved
@phunkyfish
Copy link
Member Author

Fixing the root cause would also be my preference. I didn’t realise this was the same issue (or at least very similar) until I came across it on this addon.

@phunkyfish phunkyfish changed the title [WIP] Boot crash fix matrix Boot crash fix matrix Oct 25, 2019
@phunkyfish
Copy link
Member Author

Also add the new settings format. Ready to do if you are ok with it @Jalle19

@Jalle19
Copy link
Contributor

Jalle19 commented Oct 26, 2019

AppVeyor build failure seems unrelated?

@phunkyfish phunkyfish merged commit a3f8232 into kodi-pvr:Matrix Oct 26, 2019
@phunkyfish phunkyfish deleted the boot-crash-fix-matrix branch October 26, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants