Use C++ exceptions for better error handling #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for using C++ exceptions to skip dangerous code paths early.
Instead of returning bogus data, throw an exception to jump right to the error handler.
It's illegal to reinitialize a cRequestPacket instance, and this is a software bug, not a runtime error.
Simplify error handling in callers.
All "false" code paths have been changed to throw an exception. This is a big code simplification which also makes the code safer. Many caller locations did not check for errors.
The "new" operator throws std::bad_alloc on allocation failure. No need to check for NULL.
FernetMenta
added a commit
that referenced
this pull request
Nov 11, 2015
Use C++ exceptions for better error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.