Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] remove StdString usage #76

Merged
merged 1 commit into from
Nov 12, 2017
Merged

[cleanup] remove StdString usage #76

merged 1 commit into from
Nov 12, 2017

Conversation

Rechi
Copy link
Contributor

@Rechi Rechi commented Nov 11, 2017

fixes Windows UWP builds

ksooo
ksooo reviewed Nov 11, 2017
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog and do an addon version bump.

src/VuData.cpp Outdated

std::replace(strIcon.begin(), strIcon.end(), ':', '_');
strIcon.replace(strIcon.begin(), strIcon.end(), ':', '_');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ksooo
ksooo approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ksooo ksooo merged commit 478ae5a into kodi-pvr:master Nov 12, 2017
@Rechi Rechi deleted the cleanupStdString branch November 12, 2017 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rechi @ksooo