Added rect-dom, updated CSSPropertyOperations path #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed for react 15.4.0 where CSSPropertyOperations was moved from react/lib to react-dom/lib
|
@dano-giftbit can you please explain all the code style changes? any particular reason to include them in this PR? |
|
No reason, I just ran a |
esturcke
reviewed
Nov 19, 2016
| @@ -34,7 +34,8 @@ | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "babel-runtime": "^6.6.1", | |||
| "react": ">=0.11.0" | |||
| "react": ">=0.15.4", | |||
There was a problem hiding this comment.
Yeah that seems more correct, they both result in the installation of ^15.4.0
|
@dano-giftbit @esturcke I've made a new version of stilr, which doesn't depend on react or react-dom. I would appreciate, if you could test it, and report if you find any issues. I'll close the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37
Fixed for React 15.4.0 where CSSPropertyOperations was moved from
react/libto
react-dom/lib