Possibly incorrect test assertions for min_likes and min_retweets

[blip-lorist]

Hi there! I was working on a PR to address Issue 49.

However, I noticed some confusing discrepancies between the README and the test assertions, and wanted to clarify first before submitting PRs.

min_likes expectations:

delete-tweets/test_deletetweets.py

Line 86 in d4d9161

expected = [{"id_str": "21"}, {"id_str": "22"}]

Shouldn't the expected value be [{"id_str": "21"}] ?

According to the docs, it seems like the TweetReader should exclude any tweets with at least one or more retweet.

If you take a look at the actual TweetReader list in that test case by dropping in a breakpoint.

actual = list(TweetReader(FakeReader(tweets), min_likes=1).read())
(Pdb) actual
=> [{'id_str': '21', 'favorite_count': 0}]

---

min_retweets expectations:
Should this line

delete-tweets/test_deletetweets.py

Line 97 in d4d9161

expected = [{"id_str": "21"}, {"id_str": "22"}]

be expected = [{'id_str': '21', 'retweet_count': 0}]?
Just like the above example, inspecting the actual list in the test returns: => [{'id_str': '21', 'retweet_count': 0}]

[blip-lorist]

Since the expected lists don't match the actual lists, both of those tests are false positives. Might want to add

self.assertEqual(len(expected), len(actual))

to avoid false positives.

[koenrh]

Hi @lorainekv,

Apologies for the delayed response.

I think you are right! Feel free to submit the pull request.