Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-response-validator: add ajv options #866

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sshahar1
Copy link

This PR allow pass extra options to Ajv validator for example to allow using a discriminator.
It is equivalent to the requests PR #709

@jsdevel
Copy link
Contributor

jsdevel commented May 20, 2023

@sshahar1 plz add some tests

@sshahar1
Copy link
Author

@sshahar1 plz add some tests

Hi @jsdevel From what I see all the tests in the repo are data-driven and not based on this class, I also saw that the original PR didn't have tests. Is it okay that I add a new technique here?

@jsdevel
Copy link
Contributor

jsdevel commented May 25, 2023

@sshahar1 you should be able to add a new test pretty easily. i'd like to see this solid and not regress.

@sshahar1
Copy link
Author

@sshahar1 you should be able to add a new test pretty easily. i'd like to see this solid and not regress.

Okay, I'll update my PR. Thanks

@sshahar1
Copy link
Author

@jsdevel Hi, I figured out the test driven use cases and added 2 tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants