Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hamann #27

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Fix hamann #27

merged 2 commits into from
Nov 16, 2021

Conversation

koheiw
Copy link
Owner

@koheiw koheiw commented Nov 10, 2021

Removed weight and corrected spelling to address #26. Fortunately, computation was correct as weight has always been 1.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #27 (73c3307) into master (bf4603e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   99.45%   99.46%           
=======================================
  Files           4        4           
  Lines         369      371    +2     
=======================================
+ Hits          367      369    +2     
  Misses          2        2           
Impacted Files Coverage Δ
R/proxy.R 99.06% <100.00%> (+0.01%) ⬆️
src/pair.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4603e...73c3307. Read the comment docs.

@koheiw koheiw merged commit 8c1c81e into master Nov 16, 2021
@koheiw koheiw deleted the fix-hamann branch November 16, 2021 09:41
@koheiw koheiw removed the request for review from kasperwelbers November 16, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant