bitvector pull request #53
Conversation
In the case that the lhs bitvector is shorter than the rhs bitvector, operator|= tries to 'or' in words past the end of the rhs bitvector (presumably uninitialized memory).
Right now it does. Next commit fixes this. git-svn-id: svn+ssh://svn.meraki.net/var/local/svnbase/meraki/trunk/router@83372 291e08f9-2c14-0410-acb0-c89b6de265c5
I got a coredump when calling the capacity write handler on an empty queue. I'm not 100% confident about this change, since I haven't been through all of the code. git-svn-id: svn+ssh://svn.meraki.net/var/local/svnbase/meraki/trunk/router@83373 291e08f9-2c14-0410-acb0-c89b6de265c5
|
Hey Patrick, I found another Bitvector bug while looking over your change, and fixed it. Best On Fri, Aug 10, 2012 at 1:18 AM, Patrick Verkaik
|
|
Hey Eddie, Wow, I really screwed up this pull request. Not sure how I ended up including the frontdropqueue changes in there. I see you've added a test already. I found the bug in a testie for a Meraki element that I wrote, so it wasn't appropriate for mainline. (The element has a couple of bitmap for VLANs and I was getting crazy VLANs in my set after doing a union.) Next time I'll write a separate testie. I'll pull your other fixes for Bitvector. Thanks! Patrick |
Hi Eddie,
A small bug fix for you. Let me know if it looks OK - this is my first pull request!