Support atomic_cmpxchg on architectures that define it as a function #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click uses the C-preprocessor to determine whether an architecture has defined atomic_cmpxchg. The ARM architecture (among others) defines this as an inline function, so Click will not attempt to use atomic_cmpxchg on those architectures. This causes the warning "using nonatomic approximation..." when building for SMP on ARM. Signed-off-by: Kevin Paul Herbert <kph@meraki.net>
|
Awesome, thanks, merged! I'm sorry about the delay on the other request -- it may take some more time to get to it, but I will get to it. |
kohler
added a commit
that referenced
this pull request
Sep 23, 2012
Support atomic_cmpxchg on architectures that define it as a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click uses the C-preprocessor to determine whether an architecture
has defined atomic_cmpxchg. The ARM architecture (among others)
defines this as an inline function, so Click will not attempt
to use atomic_cmpxchg on those architectures. This causes the
warning "using nonatomic approximation..." when building for SMP
on ARM.
Signed-off-by: Kevin Paul Herbert kph@meraki.net