TCPRewriter: add perform_mapping handler #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it a lot. However, can we rename the handler? The routing table elements provide |
|
Easy sell. Updated. |
|
And actually, I updated a test to poke this handler. |
This handler takes in a flow as a space-separated saddr sport daddr dport and looks for a forward mapping for that flow. If found, it returns the rewritten flow in the same format. This is useful when using a TCPRewriter to divert traffic to a proxy in userland. It allows the proxy to figure out the original destination for the flow, similar to SO_ORIGINAL_DST for Netfilter or SIOCGNATL for IP-Filter.
kohler
added a commit
that referenced
this pull request
Jul 15, 2013
TCPRewriter: add perform_mapping handler
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handler takes in a flow as a space-separated
and looks for a forward mapping for that flow. If found, it returns the rewritten flow in the same format. I went with this format for ease of parsing in userland.
This is useful when using a TCPRewriter to divert traffic to a proxy in userland. It allows the proxy to figure out the original destination for the flow, similar to SO_ORIGINAL_DST for Netfilter or SIOCGNATL for IP-Filter.