Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating support for WD Tagger #1216

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Rating support for WD Tagger #1216

merged 4 commits into from
Mar 30, 2024

Conversation

Disty0
Copy link
Contributor

@Disty0 Disty0 commented Mar 27, 2024

  • Add rating support for WD Tagger.
    Inserts rating tag as the first tag.
  • Reorder character tags to be in front of the general tags.
    Characters can get lost into the token limit if it is at the end.
    AnimagineXL also uses this order.

Also decided to squeeze in support for pin_memory for IPEX in this PR.

@sdbds
Copy link
Contributor

sdbds commented Mar 28, 2024

Suggest inserting character tags in front as well

@kohya-ss
Copy link
Owner

Thank you for this. This seems to be good. However I wonder an additional option to enable this feature will be needed, because this is a breaking change.

@Disty0
Copy link
Contributor Author

Disty0 commented Mar 29, 2024

Added --use_rating_tags and --character_tags_first.

Also did some formatting changes for arg parser part for consistency and did a few small changes over the code to make ruff happy.
These shouldn't have any affect for the functionality.

@kohya-ss kohya-ss merged commit 6ba8428 into kohya-ss:dev Mar 30, 2024
1 check passed
@kohya-ss
Copy link
Owner

Several features have been added to further comply with the Animagine format. Documentation has also been added. I'd be happy if you will check them out.

cae5aa0

@Disty0
Copy link
Contributor Author

Disty0 commented Mar 30, 2024

I like the option --character_tag_expand and will use it on my dataset.

@kohya-ss
Copy link
Owner

Without your PR I would not have come up with these features. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants