Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic font sizing in deck header fields #22

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

EnnisSec
Copy link

@EnnisSec EnnisSec commented Jan 2, 2019

Hi Kokernutz,

i really enjoy your QML mods for the S8, and I want to share with you some of the tweaks and further enhancements I made to them. Please feel free to pick and merge if you like them 👍

The first one is a simple tweak that enables QTs dynamic font sizing in the deck headers. This allows longer Titles, Artist Names or Comments to be displayed on the screens, while still defaulting to usual size for shorter ones:
img_0265
img_0268
Another example with a long Artist name:
img_0267

Cheers
Nils

This makes long Titel, Artist or Comment Fields easier to read
- Fix the Deck Header indicators interfering with Remix Decks; The four
  indicators between the Deck Header and Waveform will now be hidden
  automatically.
- New Pref.qml option 'displayDeckIndicators': The S8 has hardware
  indicators for Sync and Filter, so if you want you can now turn them
  off. When this option is off, a circular loop indicator (like the
  stock one, but slightly smaller) will be displayed in the header, as
  well as a metronome icon to indicate the Tempo Master. If both this
  and 'displayPhaseMeter' are set to 'false', the Waveform will
  automatically grow to fill the space available.
- Change Bottom Left text container name from 'extra_middle_left_text'
  to 'bottom_left'
- Adjust center and right field widths
@timkirtley
Copy link

Ah this looks awesome, I've previously just reduced the font size for comments, but dynamically changing it seems a better idea

@MrPatben8
Copy link
Contributor

MrPatben8 commented Jan 15, 2019

Fantastic work! This was much needed! You should try and add this feature to the S5 and D2. I hope @kokernutz will merge your changes to the master.

@EnnisSec
Copy link
Author

You should try and add this feature to the S5 and D2.

I guess if we made similar changes to their scripts it should work just the same for them, but I don't have the controllers to check if it actually works and looks ok. Would you be able to test that @MrPatben8?

@MrPatben8
Copy link
Contributor

MrPatben8 commented Jan 20, 2019

I guess if we made similar changes to their scripts it should work just the same for them, but I don't have the controllers to check if it actually works and looks ok. Would you be able to test that @MrPatben8?

@EnnisSec No, unfortunately I only own a S8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants