-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AES192 and AES256 #58
Conversation
This PR is dynamite! I've been wanting to refactor the base code so that the block-sizes could vary. |
BTW: I see that you've renamed your repo. I totally get the reason for that, but I won't though, because I fear it may spoil links to the project-page somewhere on the interwebz - cause it will, won't it? Just giving it a thought after reviewing your changes. |
Renaming the repo won't affect who has forked with the original name,
however, if you want to keep your name, i am good with it!!
Thank you
On Fri, Jul 7, 2017 at 17:03 kokke ***@***.***> wrote:
BTW: I see that you've renamed your repo. I totally get the reason for
that, but I won't though, because I fear it may spoil links to the
project-page somewhere on the interwebz - cause it will, won't it? Just
giving it a thought after reviewing your changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAngjfUkNomnExuwegAJojFxt47xmer5ks5sLsdUgaJpZM4ORfop>
.
--
Sent from iPhone
|
Just so you now: If you rename the repository, nothing will break. As long as you don't create a new repository under this name, GitHub will automatically redirect users to the new name: https://help.github.com/articles/renaming-a-repository/ I tried this out and it works, for both the website and git clone (https and ssh). (If you want to test it out, I can give the the old link to my project) |
Oh, if renaming doesn't break any links, I will consider it :) |
Adding new keys for 192 and 256 bits, only one length is available at a time depending on a compile time definition of AES128/AES192/AES256