Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AES192 and AES256 #58

Merged
merged 17 commits into from
Jul 7, 2017
Merged

Adding AES192 and AES256 #58

merged 17 commits into from
Jul 7, 2017

Conversation

bricke
Copy link
Contributor

@bricke bricke commented Jul 7, 2017

Adding new keys for 192 and 256 bits, only one length is available at a time depending on a compile time definition of AES128/AES192/AES256

  • AES128 compiles with 128b keys support
  • AES192 compiles with 192b keys support
  • AES256 compiles with 256b keys support

@kokke
Copy link
Owner

kokke commented Jul 7, 2017

This PR is dynamite! I've been wanting to refactor the base code so that the block-sizes could vary.
Thank you for taking the effort to updating this project to support the two larger block-size.
Also I'm happy to see that you've kept the code in the same style as originally.

@kokke kokke merged commit 4fd333e into kokke:master Jul 7, 2017
@kokke
Copy link
Owner

kokke commented Jul 8, 2017

BTW: I see that you've renamed your repo. I totally get the reason for that, but I won't though, because I fear it may spoil links to the project-page somewhere on the interwebz - cause it will, won't it? Just giving it a thought after reviewing your changes.

@bricke
Copy link
Contributor Author

bricke commented Jul 8, 2017 via email

@Skycoder42
Copy link

Just so you now: If you rename the repository, nothing will break. As long as you don't create a new repository under this name, GitHub will automatically redirect users to the new name: https://help.github.com/articles/renaming-a-repository/

I tried this out and it works, for both the website and git clone (https and ssh). (If you want to test it out, I can give the the old link to my project)

@kokke
Copy link
Owner

kokke commented Jul 13, 2017

Oh, if renaming doesn't break any links, I will consider it :)
Thanks for pointing it out @Skycoder42 and @bricke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants