Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] SpaceTimeStack export data into JSON format #114

Merged
merged 4 commits into from
Feb 10, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Nov 30, 2020

Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

profiling/space-time-stack/kp_space_time_stack.cpp Outdated Show resolved Hide resolved
@DavidPoliakoff
Copy link
Contributor

Actually, another bug with ExaMiniMD:

  120 {
  121 "average-time" : 4.38e-03,
  122 "percent" : 0.1,
  123 "percent-kokkos" : 199.5,
  124 "imbalance" : 0.0,
  125 "remainder" : "N/A",
  126 "kernels-per-second" : "N/A",
  127 "number-of-calls" : 39,
>>128 "name" : ""CommMPI::pack_count"="Scalar"",
  129 "parent-id" : "0xe4a370",
  130 "id" : "0xe4a410",
  131 "kernel-type" : "copy"
  132 },

Apparently something in how this string is quoted is breaking... all the joys of I/O libraries ;)

@nmhamster
Copy link
Contributor

FYI - JSON double quotation marks inside a string must be escaped with \"

@DavidPoliakoff
Copy link
Contributor

@nmhamster : are you still allowed to do technical work? :p

@dalg24
Copy link
Member Author

dalg24 commented Feb 4, 2021

Fixed the double quote bug

@DavidPoliakoff
Copy link
Contributor

@dalg24, I think my suggestion was broken in how it got applied, could you check that
c24900a does what you want?

@dalg24
Copy link
Member Author

dalg24 commented Feb 10, 2021

@dalg24, I think my suggestion was broken in how it got applied, could you check that
c24900a does what you want?

It does

@DavidPoliakoff DavidPoliakoff merged commit df0e83b into kokkos:develop Feb 10, 2021
@dalg24 dalg24 deleted the space_time_stack_export_json branch February 10, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants