Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KokkosCI.cmake, KokkosCTest.cmake.in, CTestConfig.cmake.in + CI updates #2844

Merged
merged 31 commits into from
Jan 14, 2021
Merged

KokkosCI.cmake, KokkosCTest.cmake.in, CTestConfig.cmake.in + CI updates #2844

merged 31 commits into from
Jan 14, 2021

Conversation

jrmadsen
Copy link
Contributor

@jrmadsen jrmadsen commented Mar 6, 2020

  • Added support for using CDash dashboard at NERSC to travis and jenkins

@jrmadsen jrmadsen requested review from dalg24 and crtrott March 6, 2020 23:28
@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@jrmadsen
Copy link
Contributor Author

jrmadsen commented Mar 6, 2020

Lets see if it works since the Travis and Jenkins jobs here should be reporting to the dashboard...

@dalg24
Copy link
Member

dalg24 commented Mar 7, 2020

Add to whitelist

dalg24
dalg24 reviewed Mar 7, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@jrmadsen jrmadsen requested a review from dalg24 March 8, 2020 22:30
@dalg24
Copy link
Member

dalg24 commented Mar 9, 2020

@jrmadsen I think PRs builds should submit to the experimental dashboard. Also, more importantly, the PR-number needs to be displayed for each build

@jrmadsen
Copy link
Contributor Author

jrmadsen commented Mar 9, 2020

@dalg24 So I commonly build an automated system for these sort of things, e.g. look at build flags like -DKokkos_ENABLE_CUDA=ON -DKokkos_ENABLE_OPENMP=ON and generate a unique build name suffix like CUDA-OPENMP, etc. I know I can distinguish PRs in the Travis env but I am less familiar with how to extract this info from Jenkins.

@dalg24
Copy link
Member

dalg24 commented Mar 9, 2020

@dalg24 So I commonly build an automated system for these sort of things, e.g. look at build flags like -DKokkos_ENABLE_CUDA=ON -DKokkos_ENABLE_OPENMP=ON and generate a unique build name suffix like CUDA-OPENMP, etc. I know I can distinguish PRs in the Travis env but I am less familiar with how to extract this info from Jenkins.

https://jenkins.io/doc/book/pipeline/jenkinsfile/#using-environment-variables

@jrmadsen
Copy link
Contributor Author

jrmadsen commented Mar 9, 2020

Oh I didn't finish that first though, while I am doing the PR stuff, should I add a system for auto-generating a unique tag based on options? This is beneficial bc you can look at how long test run over time based on the build name and site so a system like this helps ensure this timeline does not contain data points from configurations with slightly different settings

@jrmadsen
Copy link
Contributor Author

@dalg24 Having tried to find an error in the AppVeyor output in #3627, I really think we need to revisit this, but you had some very specific desires about how this is should be set up so I would prefer if we just hopped on a zoom for an hour or so and sorted it out live instead of iterating over the changes here.

jrmadsen and others added 3 commits December 14, 2020 16:32
@jrmadsen
KokkosCI.cmake, KokkosCTest.cmake.in, CTestConfig.cmake.in + CI updates
a4062c2 
- Added support for using CDash dashboard at NERSC to travis and jenkins
@dalg24 @jrmadsen
Fixup path to nvcc_wrapper in CTest script
41860ef
@jrmadsen
Update KokkosCI.cmake
59b8049 
- Added build name tagging for PRs
- Update CTestConfig.cmake.in to exclude tpls in coverage
- Capture cmake configuration arguments via cached variables instead of configuration stuff being inside KokkosCI.cmake
- Updated travis
- Updated jenkins
- Updated appveyor.yml
dalg24
dalg24 reviewed Jan 7, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The console output on Jenkins does not show the configure and the build steps

.jenkins Show resolved Hide resolved
.jenkins Outdated Show resolved Hide resolved
cmake/CTestConfig.cmake.in Show resolved Hide resolved
cmake/CTestConfig.cmake.in Outdated Show resolved Hide resolved
cmake/KokkosCTest.cmake.in Show resolved Hide resolved
@jrmadsen jrmadsen requested a review from dalg24 January 12, 2021 23:01
@jrmadsen
Copy link
Contributor Author

@crtrott @dalg24

dalg24
dalg24 reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge on my end after you apply the suggestions

.jenkins Outdated Show resolved Hide resolved
.jenkins Outdated Show resolved Hide resolved
masterleinad
masterleinad reviewed Jan 13, 2021
View reviewed changes
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
masterleinad
masterleinad approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well.

jrmadsen
jrmadsen commented Jan 13, 2021
View reviewed changes
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
jrmadsen
jrmadsen commented Jan 13, 2021
View reviewed changes
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
jrmadsen
jrmadsen commented Jan 13, 2021
View reviewed changes
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
jrmadsen
jrmadsen commented Jan 13, 2021
View reviewed changes
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
jrmadsen
jrmadsen commented Jan 13, 2021
View reviewed changes
cmake/KokkosCI.cmake Outdated Show resolved Hide resolved
@jrmadsen @dalg24
Apply suggestions from code review
b9c9980 
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@masterleinad
Copy link
Contributor

Retest this please.

1 similar comment
@masterleinad
Copy link
Contributor

Retest this please.

@crtrott crtrott merged commit fb2a0f8 into kokkos:develop Jan 14, 2021
@jrmadsen jrmadsen deleted the nersc-cdash branch January 15, 2021 01:58
@masterleinad masterleinad mentioned this pull request Jun 22, 2021
Merged
masterleinad added a commit to masterleinad/kokkos that referenced this pull request Jun 22, 2021
@masterleinad
Revert "KokkosCI.cmake, KokkosCTest.cmake.in, CTestConfig.cmake.in + …
d40eda6 
…CI updates (kokkos#2844)"

This reverts commit fb2a0f8.
masterleinad added a commit to masterleinad/kokkos that referenced this pull request Jun 23, 2021
@masterleinad
Revert "KokkosCI.cmake, KokkosCTest.cmake.in, CTestConfig.cmake.in + …
f0edabd 
…CI updates (kokkos#2844)"

This reverts commit fb2a0f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

@masterleinad masterleinad masterleinad approved these changes

@crtrott crtrott Awaiting requested review from crtrott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrmadsen @dalg24-jenkins @dalg24 @masterleinad @crtrott