This makes the math function use the "C" interface for GCC 5 #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with: using CUDA 10.1 and GCC 5.3 |
| @@ -91,8 +91,12 @@ namespace Experimental { | |||
| #if defined(KOKKOS_ENABLE_SYCL) | |||
| #define KOKKOS_IMPL_MATH_FUNCTIONS_NAMESPACE sycl | |||
| #else | |||
| #if defined(KOKKOS_ENABLE_CUDA) && defined(__GNUC__) && (__GNUC__ < 6) | |||
There was a problem hiding this comment.
Is it a problem that this path might also be taken by a compiler different from g++, like icpc or clang++?
There was a problem hiding this comment.
what do you mean? The issue is the C++ cmath header, which should only depend on the GNUC
There was a problem hiding this comment.
or are you worried this is getting taken by clang when it is supposed to use its own headers?
There was a problem hiding this comment.
clang doesn't like this:
/var/jenkins/workspace/Kokkos/core/src/Kokkos_MathematicalFunctions.hpp:298:34: error: reference to __device__ function 'isinf' in __host__ __device__ function [clang-diagnostic-error]
When compiling for CUDA with GCC 5 the std::functions don't have the right markup, so you get all these warnings or errors about calling pure host functions in our math functions. Prior to GCC 6 you have to call for example fmin instead of std::fmin
crtrott
force-pushed
the
fix-cuda-with-gcc5
branch
from
7c9bf21
to
6943996
Compare
|
Retest this please. |
|
Retest this please |
1 similar comment
|
Retest this please |
|
Failures are unrelated |
dalg24
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling for CUDA with GCC 5 the std::functions don't have
the right markup, so you get all these warnings or errors about
calling pure host functions in our math functions.
Prior to GCC 6 you have to call for example fmin instead of std::fmin