Mark as_view_of_rank_n as KOKKOS_FUNCTION

[masterleinad]

We are using this function in other KOKKOS_FUNCTION functions.

[PhilMiller]

Thanks. Sorry I missed this when I added it

[crtrott]

Approving, come to think of that however it feels like the specialization of as_view_of_rank_n for normal Views probably should move to Kokkos_DynRankView too.

[PhilMiller]

Approving, come to think of that however it feels like the specialization of as_view_of_rank_n for normal Views probably should move to Kokkos_DynRankView too.

I think I had some reason for keeping it there, perhaps to support other things that might need genericity over rank (hello, Sacado), separate from DynRankView. I don't recall exactly, though. Generally, I think it's probably good form to not have the implementation for some bit of generic code on View living in an optional container

[PhilMiller]

Switching from an exception to Kokkos::abort means that the unit test for the error case can no longer catch it.

[dalg24]

Death test is an option but doing it on the device gets annoying pretty quickly considering the current support in various backends

[PhilMiller]

Having seen the error case test working previously, I'd be ok with dropping it

Tests do not pass

[dalg24]

Failure are unrelated (machine ran out of disk space)