Move Kokkos::Array
tests to a more suitable place
#6905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: new place is a better fit and upcoming changes to view of Kokkos arrays where the remaining tests in that file would be removed
The
Kokkos::Array
tests are move from runtimeview_aggregate
test toTestArray.cpp
that currently had CTAD compile-only tests. I split the tests into "aggregate initialization" and "zero-sized array code that must compile" and refactored to get the assertions checked at compile time. I did not really want to refactor further and actually run code on the device. I think that is good enough, the tests are easier to find and fairly readable.These tests were introduced in 2017 and placed here for lack of a better place.