-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around MSVC+Cuda CI failure #7068
Conversation
We are now getting error messages like
|
These are the exact messages |
|
It's already using that.
|
Well, back to the drawing board then. |
:-( |
5a0be5a
to
1e5e59d
Compare
97912b8
to
92fe397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to TestMDSpanConversion needs to be undone or?
static_assert(is_layout_stride); | ||
return m_map.m_impl_handle[j0 * m_map.m_impl_offset.m_stride.S0 + | ||
j1 * m_map.m_impl_offset.m_stride.S1]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is anyway a positive change.
92fe397
to
90d8770
Compare
Just removed that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
After the windows-2022 was updated in the GitHub runner we were seeing.
This pull request fixes that by updating Cuda to the latest available version in the action used for installing it.