Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around MSVC+Cuda CI failure #7068

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented Jun 12, 2024

After the windows-2022 was updated in the GitHub runner we were seeing.

C:\Program Files\NVIDIA GPU Computing
Toolkit\CUDA\v12.1\include\crt/host_config.h(153): fatal error C1189:
#error: -- unsupported Microsoft Visual Studio version! Only the versions
between 2017 and 2022 (inclusive) are supported! The nvcc flag
'-allow-unsupported-compiler' can be used to override this version check;
however, using an unsupported host compiler may cause compilation failure
or incorrect run time execution. Use at your own risk.
[D:\a\kokkos\kokkos\build\CMakeFiles\3.29.3\CompilerIdCUDA\CompilerIdCUDA.vcxproj]

This pull request fixes that by updating Cuda to the latest available version in the action used for installing it.

@masterleinad
Copy link
Contributor Author

We are now getting error messages like

D:/a/kokkos/kokkos/core/src\Kokkos_View.hpp(976): error C2535: 'enable_if<Kokkos::Impl::always_true<I0,I1>::value&&2=='function'&&true&&false&&'function'==0,double&>::type Kokkos::View<double *,Kokkos::LayoutStride>::operator ()(I0,I1) const': member function already defined or declared [D:\a\kokkos\kokkos\build\algorithms\unit_tests\Kokkos_UnitTest_Sort.vcxproj]
  D:/a/kokkos/kokkos/core/src\Kokkos_View.hpp(954): note: see declaration of 'Kokkos::View<double *,Kokkos::LayoutStride>::operator ()'
  D:/a/kokkos/kokkos/core/src\Kokkos_View.hpp(976): note: the template instantiation context (the oldest one first) is
  D:/a/kokkos/kokkos/algorithms/unit_tests\TestStdAlgorithmsCommon.hpp(664): note: see reference to class template instantiation 'Kokkos::View<double *,Kokkos::LayoutStride>' being compiled

@aprokop
Copy link
Collaborator

aprokop commented Jun 12, 2024

We are now getting error messages like

These are the exact messages ArborX is getting after that cursed Windows image update.

@aprokop
Copy link
Collaborator

aprokop commented Jun 12, 2024

actions/runner-images pushed 20240610.1 yesterday. Just need to wait until it deploys.

@masterleinad
Copy link
Contributor Author

actions/runner-images pushed 20240610.1 yesterday. Just need to wait until it deploys.

It's already using that.

Runner Image
  Image: windows-2022
  Version: 20240610.1.0
  Included Software: https://github.com/actions/runner-images/blob/win22/20240610.1/images/windows/Windows2022-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20240610.1

@aprokop
Copy link
Collaborator

aprokop commented Jun 12, 2024

It's already using that.

Well, back to the drawing board then.

@crtrott
Copy link
Member

crtrott commented Jun 12, 2024

:-(

@masterleinad masterleinad force-pushed the fix_msvc_cuda branch 2 times, most recently from 97912b8 to 92fe397 Compare June 13, 2024 15:23
Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to TestMDSpanConversion needs to be undone or?

static_assert(is_layout_stride);
return m_map.m_impl_handle[j0 * m_map.m_impl_offset.m_stride.S0 +
j1 * m_map.m_impl_offset.m_stride.S1];
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is anyway a positive change.

@masterleinad
Copy link
Contributor Author

The change to TestMDSpanConversion needs to be undone or?

Just removed that change.

@masterleinad masterleinad marked this pull request as ready for review June 13, 2024 17:23
Copy link
Collaborator

@aprokop aprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants