Use mdspan-0.3.0 tag #236
Merged
Use mdspan-0.3.0 tag #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdspan will soon experience a backwards compatibility - breaking change. Please see info here: kokkos/mdspan#136 This commit temporarily changes stdBLAS to use the indicated pre-change mdspan tag for github-based tests.
Previous build used CMake 3.13. I imitated the current kokkos/mdspan build.
mhoemmen
force-pushed
the
use-mdspan-0.3.0-tag
branch
from
24f4341
to
67ac421
Compare
GCC < 10 implements parallel execution policies using TBB. Building GCC with TBB is optional. If GCC wasn't built with TBB, then including <execution> fails, because it unconditionally includes a TBB header file. This commit words around that, for the examples in stdBLAS.
mhoemmen
force-pushed
the
use-mdspan-0.3.0-tag
branch
from
017db0e
to
918999c
Compare
This will help us get the PR test workflow running again so that we can change to use the mdspan-0.3.0 tag.
This will help us get the PR test workflow running again so that we can change to use the mdspan-0.3.0 tag.
mhoemmen
force-pushed
the
use-mdspan-0.3.0-tag
branch
from
345de7f
to
a607be8
Compare
crtrott
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdspan will soon experience a backwards compatibility - breaking change.
Please see info here: kokkos/mdspan#136
This commit temporarily changes stdBLAS to use the indicated pre-change mdspan tag for github-based tests,
and to fetch that tag (rather than the stable tag) when CMake needs to fetch and build mdspan.