Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance monitoring to launcher's osquery runtime #107

Closed
marpaia opened this issue Aug 29, 2017 · 1 comment
Closed

Add performance monitoring to launcher's osquery runtime #107

marpaia opened this issue Aug 29, 2017 · 1 comment

Comments

@marpaia
Copy link
Contributor

marpaia commented Aug 29, 2017

As a result of #95, we disabled osquery's watchdog functionality in #103. The underlying reason WHY the extension wouldn't start up is because when the launcher starts an osquery instance, a fake shell binary is launched as the extension. The launcher itself then registers with the osqueryd process, providing the plugins. When osqueryd restarts itself, it relaunches the extension binary, but since this is just a shell binary, the launcher has no way of knowing to re-register the extension plugins. Thus, we disable the watchdog, since it does nothing but harm the health of the instance. As a result of this, however, we need to add our own performance checks and logging to the launcher to ensure that osquery stays well-behaved.

@directionless
Copy link
Contributor

Note: This was never implemented, and may not make sense. This it was closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants