Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements #18

Merged
merged 44 commits into from
Jan 25, 2024
Merged

Test improvements #18

merged 44 commits into from
Jan 25, 2024

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jan 19, 2024

  • Add flare to test and to artifacts
  • Add mock k2 server for running tests against
  • Gets desktop app running in test

@RebeccaMahany RebeccaMahany force-pushed the becca/desktop branch 13 times, most recently from f6f7243 to a5101f8 Compare January 19, 2024 22:28
@RebeccaMahany RebeccaMahany force-pushed the becca/desktop branch 5 times, most recently from 6bde97c to 462f8cc Compare January 24, 2024 16:46
@RebeccaMahany RebeccaMahany marked this pull request as ready for review January 24, 2024 21:43
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is (a) awesome work and (b) okay to merge, but I do have some nits around the mock server:

  • It's not k2 it's a agent or launcher mock
  • It should probably live in the launcher repo
  • I feel very unsure about python.
  • I kinda wonder about baking into launcher directly.

But anyhow, this is awesome.

@RebeccaMahany
Copy link
Contributor Author

@directionless --

* It's not `k2` it's a `agent` or `launcher` mock

Fair -- I will update the name in the next PR. Maybe deviceserver?

* It should probably live in the launcher repo
* I feel very unsure about python. 
* I kinda wonder about baking into launcher directly.

This was just the fastest thing that I got going that actually worked, but I'm definitely happy to move it to golang, move it to another location, etc! I added a tracking item here: kolide/launcher#1532

@RebeccaMahany RebeccaMahany merged commit ebf4b90 into main Jan 25, 2024
1 check passed
@RebeccaMahany RebeccaMahany deleted the becca/desktop branch January 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants