-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test improvements #18
Conversation
RebeccaMahany
commented
Jan 19, 2024
•
edited
Loading
edited
- Add flare to test and to artifacts
- Add mock k2 server for running tests against
- Gets desktop app running in test
f6f7243
to
a5101f8
Compare
a5101f8
to
74ddc0c
Compare
09015b0
to
361e1a6
Compare
6bde97c
to
462f8cc
Compare
462f8cc
to
4f9c770
Compare
34873c0
to
91438aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is (a) awesome work and (b) okay to merge, but I do have some nits around the mock server:
- It's not
k2
it's aagent
orlauncher
mock - It should probably live in the launcher repo
- I feel very unsure about python.
- I kinda wonder about baking into launcher directly.
But anyhow, this is awesome.
Fair -- I will update the name in the next PR. Maybe
This was just the fastest thing that I got going that actually worked, but I'm definitely happy to move it to golang, move it to another location, etc! I added a tracking item here: kolide/launcher#1532 |