Fix coverage #25
Merged
Fix coverage #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in test options in project.json is being detected
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 65a315c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
koliveira15
requested changes
Apr 11, 2023
package-lock.json
Outdated
| @@ -43,10 +43,12 @@ describe('nx-sonarqube e2e', () => { | |||
| it( | |||
| 'should generate test coverage, configure nx-sonarqube target, & include static and implicit sources in the scan', | |||
| async () => { | |||
| // await runNxCommandAsync( | |||
koliveira15
requested changes
Apr 11, 2023
| @@ -47,7 +47,16 @@ async function determinePaths( | |||
| sources.push(dep.sourceRoot); | |||
|
|
|||
| if (dep.testTarget) { | |||
| if (dep.testTarget.options.jestConfig) { | |||
| if (dep.testTarget.options.coverageDirectory) { | |||
There was a problem hiding this comment.
unit test should cover this branching and be 100%. check the CI run for more details
There was a problem hiding this comment.
I covered it in the e2e test. I will add a unit test to check this case.
koliveira15
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow nx-sonarqube plugin to detect coverageDirectory and properly add coverage files.