-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable js data is deserialized with errors #19
Comments
I've created PR with fix. |
This should be closed via #7 right? |
It was resolved with this pr |
This was referenced Dec 1, 2018
zalmoxisus
added a commit
to zalmoxisus/redux-devtools-extension
that referenced
this issue
Dec 8, 2018
HadesHappy
added a commit
to HadesHappy/redux-devtools-extension
that referenced
this issue
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi guys,
I'm using
redux-persist
which usesremotedev-serialize
which uses your package for (de)serialization of theImmutable js
app state.When several properties in the object tree have the same values then
jsan
tries to reuse first entry of the value using references to it in other places.For example:
after serialization will be
But with
Immutable js
during the serializationremotedev-serialize
with help ofjsan
converts immutable js structures into it's own representation and serializes it.So the references for the same values are built over the converted structure instead of the original
Immutable js
structures.And during the deserialization
jsan
first transforms its own representation to the originalImmutable js
structure and only after that trying to resolve references for the same values but fails and always returnsundefined
cuz such references for its own representation can't be resolved on the originalImmutable js
structure.jsan/lib/index.js
Lines 43 to 50 in a37187a
The text was updated successfully, but these errors were encountered: