Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify API and Update Documentation #3

Merged
merged 2 commits into from
Apr 12, 2016
Merged

Simplify API and Update Documentation #3

merged 2 commits into from
Apr 12, 2016

Conversation

aldendaniels
Copy link
Collaborator

Changes:

  1. Add detailed and update documentation
  2. Change createCustomChecker to
    • Take a checker directly instead of a function that returns a checker
    • Internally handle missing data
    • Prefix custom error messages with the location of the error
  3. Remove createSimpleChecker since createCustomChecker is now also simple, but is more powerful.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 98.833% when pulling 033932d on simplify-api-and-document into 2558070 on master.

@aldendaniels
Copy link
Collaborator Author

@kolodny - Could you take a look at this and then merge/publish at your earliest convenience? Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 98.75% when pulling 58aa769 on simplify-api-and-document into 2558070 on master.

@kolodny kolodny merged commit 58aa769 into master Apr 12, 2016
@kolodny
Copy link
Owner

kolodny commented Apr 12, 2016

published to 3.1.0

@aldendaniels aldendaniels deleted the simplify-api-and-document branch April 14, 2016 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aldendaniels @coveralls @kolodny