Adjust envelope value to smooth transition from attack to release #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Propositional fix for kometbomb/klystrack#265 |
|
The comments are wrapped to not exceed 80 col, but I realize that the 80 col limit is not followed on this code base, would you rather have them de-wrapped? |
ngeiswei
force-pushed
the
smooth-attack-to-release
branch
from
f9483e8
to
c6832e2
Compare
|
Never mind, I've re-pushed to conform closer to the code base style. |
ngeiswei
force-pushed
the
smooth-attack-to-release
branch
from
c6832e2
to
9fab3c1
Compare
Given that attack and release have two different profiles (attack is linear, while release is quadratic), triggering release in the middle of attack would yield a discontinuity in the amp factor calculated in cyd_env_output.
ngeiswei
force-pushed
the
smooth-attack-to-release
branch
from
9fab3c1
to
0993338
Compare
|
Great, thanks. I think this could be behind a compile flag so the old
behavior can be compiled in if needed. I can update the PR.
la 23. helmikuuta 2019 klo 10.55 Nil Geisweiller <notifications@github.com>
kirjoitti:
… Never mind, I've re-pushed to conform closer to the code base style.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCK6dcmm-KraEcpSEc_ATjBdPNy0Uy9ks5vQQICgaJpZM4bN1KV>
.
|
|
Whoa, sorry for the whitespace changes. Anyways, here are my little changes. |
|
That's a lot of air, fresh and pure straight from Finland :-D |
LTVA1
added a commit
to LTVA1/klystron
that referenced
this pull request
May 4, 2023
LTVA1
added a commit
to LTVA1/klystrack
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that attack and release have two different profiles (attack is
linear, while release is quadratic), triggering release in the middle
of attack would yield a discontinuity in the amp factor calculated in
cyd_env_output.