Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CapsList type #197

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Remove CapsList type #197

merged 3 commits into from
Dec 27, 2022

Conversation

EdwinGuayacan
Copy link
Contributor

@EdwinGuayacan EdwinGuayacan commented Dec 27, 2022 •
edited
Loading

Fixes #172

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@EdwinGuayacan EdwinGuayacan changed the title 172 remove caps list Remove caps list Dec 27, 2022
@EdwinGuayacan EdwinGuayacan changed the base branch from main to v0.12 December 27, 2022 16:06
@EdwinGuayacan EdwinGuayacan linked an issue Dec 27, 2022 that may be closed by this pull request
Remove CapsList #172
Closed
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review December 27, 2022 16:11
@EdwinGuayacan EdwinGuayacan changed the title Remove caps list Remove CapsList type Dec 27, 2022
L-Zuluaga
L-Zuluaga approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I left a couple of comments that are more a suggestion, because I'm not sure if they are better alternatives that the ones you provided. Other than that nice work 🚀

lib/types/optional_caps_list.ex Show resolved Hide resolved
lib/types/signer.ex Show resolved Hide resolved
@EdwinGuayacan EdwinGuayacan merged commit 5b7bcb0 into kommitters:v0.12 Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Zuluaga L-Zuluaga L-Zuluaga approved these changes

@miguelnietoa miguelnietoa Awaiting requested review from miguelnietoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CapsList
3 participants
@EdwinGuayacan @L-Zuluaga @miguelnietoa