Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CommandsList type #198

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Remove CommandsList type #198

merged 3 commits into from
Dec 27, 2022

Conversation

EdwinGuayacan
Copy link
Contributor

Fixes #173

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@EdwinGuayacan EdwinGuayacan changed the title Remove commands list Remove CommandsList type Dec 27, 2022
@EdwinGuayacan EdwinGuayacan linked an issue Dec 27, 2022 that may be closed by this pull request
Remove CommandsList #173
Closed
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review December 27, 2022 20:29
L-Zuluaga
L-Zuluaga previously approved these changes Dec 27, 2022
View reviewed changes
@EdwinGuayacan EdwinGuayacan merged commit fd69828 into kommitters:v0.12 Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

@L-Zuluaga L-Zuluaga L-Zuluaga left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CommandsList
3 participants
@EdwinGuayacan @L-Zuluaga @miguelnietoa